Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v8_6_x: 6.2.414.27 -> 6.9.427.14 #46113

Merged
merged 1 commit into from Oct 8, 2018
Merged

v8_6_x: 6.2.414.27 -> 6.9.427.14 #46113

merged 1 commit into from Oct 8, 2018

Conversation

taktoa
Copy link
Member

@taktoa taktoa commented Sep 5, 2018 •
edited

Motivation for this change

6.2 is a pretty old version. I've done some minimal testing of the output binaries but other than that I haven't really tested this much. The only packages depending on v8_6_x are the PHP packages v8 and v8js and the top-level package plv8.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@srhb
Copy link
Contributor

srhb commented Sep 6, 2018

@GrahamcOfBorg build v8_6_x

@GrahamcOfBorg
Copy link

Unexpected error: command failed with exit code 1 on aarch64-linux (full log)

Attempted: v8_6_x

Partial log (click to expand)

 * [new branch]          promise-constructor-override -> origin/promise-constructor-override
 * [new branch]          remove-issafeinteger-followup -> origin/remove-issafeinteger-followup
 * [new branch]          revert-1064-class-fields -> origin/revert-1064-class-fields
 * [new branch]          revert-1141-ArrayIteratorPrototype-next -> origin/revert-1141-ArrayIteratorPrototype-next
 * [new branch]          revert-1150-revert-1064-class-fields -> origin/revert-1150-revert-1064-class-fields
 * [new branch]          revert-1176-1051       -> origin/revert-1176-1051
Switched to a new branch 'fetchgit'
removing `.git'...
cannot build derivation '/nix/store/b14877i7n3vi401wrk3a821gm8ilzar0-v8-6.9.427.14.drv': 1 dependencies couldn't be built
error: build of '/nix/store/b14877i7n3vi401wrk3a821gm8ilzar0-v8-6.9.427.14.drv' failed

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: v8_6_x

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Unexpected error: command failed with exit code 1 on x86_64-linux (full log)

Attempted: v8_6_x

Partial log (click to expand)

 * [new branch]          promise-constructor-override -> origin/promise-constructor-override
 * [new branch]          remove-issafeinteger-followup -> origin/remove-issafeinteger-followup
 * [new branch]          revert-1064-class-fields -> origin/revert-1064-class-fields
 * [new branch]          revert-1141-ArrayIteratorPrototype-next -> origin/revert-1141-ArrayIteratorPrototype-next
 * [new branch]          revert-1150-revert-1064-class-fields -> origin/revert-1150-revert-1064-class-fields
 * [new branch]          revert-1176-1051       -> origin/revert-1176-1051
Switched to a new branch 'fetchgit'
removing `.git'...
cannot build derivation '/nix/store/q3k5zpxy692k3wnqv1nh5qjxjgr2jyqr-v8-6.9.427.14.drv': 1 dependencies couldn't be built
error: build of '/nix/store/q3k5zpxy692k3wnqv1nh5qjxjgr2jyqr-v8-6.9.427.14.drv' failed

@srhb
Copy link
Contributor

srhb commented Sep 6, 2018

fixed-output derivation produced path '/nix/store/lv3zcwlgfjv38h5a4z1h685rra8ph8jy-spec-2113ea7' with sha256 hash '07aw7x2xzmzk905mqf8gbbb1bi1a5kv99g8iv6x2p07d3zns7xzx' instead of the expected hash '1c32mqgbq8afwwaazjhzjd0dpwd4k0vsibvhijmph89yvaydd8bq'

@taktoa
Copy link
Member Author

taktoa commented Sep 7, 2018

Ah, this is because I did nix-prefetch-git without --fetch-submodules to get that hash.

@srhb
Copy link
Contributor

srhb commented Sep 7, 2018

@GrahamcOfBorg build v8_6_x

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: v8_6_x

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Unexpected error: command failed with exit code 1 on aarch64-linux (full log)

Attempted: v8_6_x

Partial log (click to expand)

Unable to checkout 2113ea7e106f8a964e0445ba38f289d2aa845edd from https://chromium.googlesource.com/external/github.com/WebAssembly/spec.git.
builder for '/nix/store/m42249vjb3px6p8k41vz2h4anxvm96sg-spec-2113ea7.drv' failed with exit code 1
error: RPC failed; curl 56 OpenSSL SSL_read: SSL_ERROR_SYSCALL, errno 104
fatal: The remote end hung up unexpectedly
fatal: early EOF
fatal: index-pack failed
Unable to checkout a6c1d05ac4fed084fa047e4c52ab2a8c9c2a8aef from https://chromium.googlesource.com/external/github.com/tc39/test262.git.
builder for '/nix/store/xjmcd5f6lkyrvwkkh5fyl44s4kl3r2w2-test262-a6c1d05.drv' failed with exit code 1
cannot build derivation '/nix/store/fmnvr7d7rpz34alm8f2k11bsxsppchr4-v8-6.9.427.14.drv': 2 dependencies couldn't be built
error: build of '/nix/store/fmnvr7d7rpz34alm8f2k11bsxsppchr4-v8-6.9.427.14.drv' failed

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-linux (full log)

Attempted: v8_6_x

Partial log (click to expand)

[1215/1324] STAMP obj/v8_base.stamp
[1216/1324] STAMP obj/v8_initializers.stamp
[1217/1324] STAMP obj/v8_nosnapshot.stamp
[1218/1324] STAMP obj/v8_init.stamp
[1219/1324] LINK ./mksnapshot
[1220/1324] ACTION //:run_mksnapshot_default(//build/toolchain/linux:x64)
[1221/1324] STAMP obj/run_mksnapshot_default.stamp
[1222/1324] STAMP obj/d8.inputdeps.stamp
building of '/nix/store/bnixqsy1p6ymq6r3lgbsivrhywcx1kzm-v8-6.9.427.14.drv' timed out after 1800 seconds
error: build of '/nix/store/bnixqsy1p6ymq6r3lgbsivrhywcx1kzm-v8-6.9.427.14.drv' failed

@matthewbauer matthewbauer merged commit 514bfd7 into NixOS:master Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@taktoa @srhb @GrahamcOfBorg @matthewbauer