Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/thefuck: move init scripts to programs.*.interactiveShellInit #42356

Merged
merged 1 commit into from Jun 22, 2018

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Jun 21, 2018

Motivation for this change

fuck should only be used for interactive sessions, but nothing more
(so init files like /etc/zshenv become even more lightweight).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

`fuck` should only be used for interactive sessions, but nothing more
(so init files like `/etc/zshenv` become even more lightweight).
@Ma27
Copy link
Member Author

Ma27 commented Jun 21, 2018

checked inside a VM with the following configuration:

{
  test = {
    users.extraUsers.vm = {
      initialPassword = "vm";
      extraGroups = [ "wheel" ];
    };

    programs = {
      fish.enable = true;
      zsh.enable = true;
      thefuck.enable = true;
    };
  };
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants