Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3 distutils patch maintenance #42925

Merged
merged 2 commits into from Jul 3, 2018
Merged

python3 distutils patch maintenance #42925

merged 2 commits into from Jul 3, 2018

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Jul 3, 2018

Motivation for this change

Fix #39576 (comment)
cc @vcunat

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@veprbl veprbl requested a review from FRidh as a code owner July 3, 2018 17:31
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python36, python37

Partial log (click to expand)

copying path '/nix/store/rwn23z99vnbcq1px1vk8pmabawff7i0z-sqlite-3.24.0' from 'https://cache.nixos.org'...
copying path '/nix/store/lqnf05qdjshwijs9dr3klzk31y4qkj2g-coreutils-8.29' from 'https://cache.nixos.org'...
copying path '/nix/store/5lngsma59wrh8bk0yc469shar788ii5i-readline-6.3p08' from 'https://cache.nixos.org'...
copying path '/nix/store/pngyllkbhkjvbkmwg1k6nhf1mx9775w6-perl-5.24.4' from 'https://cache.nixos.org'...
copying path '/nix/store/dn3lkiwcd63r26cq9k5v3vpimn5dw8sl-python3-3.6.6' from 'https://cache.nixos.org'...
copying path '/nix/store/a0w685vyychvsi91x4mh4f592hyazfyg-openssl-1.0.2o-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/rna5x7mlm79vvzaga2k4nbcx4yvjr49y-openssl-1.0.2o-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/qyzfpwskrzhi10xf0mk2mz49v3jz6yj8-python3-3.7.0' from 'https://cache.nixos.org'...
/nix/store/dn3lkiwcd63r26cq9k5v3vpimn5dw8sl-python3-3.6.6
/nix/store/qyzfpwskrzhi10xf0mk2mz49v3jz6yj8-python3-3.7.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python36, python37

Partial log (click to expand)

these paths will be fetched (9.89 MiB download, 56.74 MiB unpacked):
  /nix/store/pdskgi8f0w2c4b0hl11d23qqzlnira16-python3-3.7.0
copying path '/nix/store/pdskgi8f0w2c4b0hl11d23qqzlnira16-python3-3.7.0' from 'https://cache.nixos.org'...
/nix/store/ihxxqhpdx3v06la2h02mgqkfvfhhymv3-python3-3.6.6
/nix/store/pdskgi8f0w2c4b0hl11d23qqzlnira16-python3-3.7.0

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: python36, python37

Partial log (click to expand)

    if (openpty(&master_fd, &slave_fd, NULL, NULL, NULL) != 0)
        ^
./Modules/posixmodule.c:6018:11: error: implicit declaration of function 'forkpty' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
    pid = forkpty(&master_fd, NULL, NULL, NULL);
          ^
./Modules/posixmodule.c:6018:11: warning: this function declaration is not a prototype [-Wstrict-prototypes]
2 warnings and 2 errors generated.
make: *** [Makefile:1793: Modules/posixmodule.o] Error 1
builder for '/nix/store/1mpwdflyqkmkjxknpkzfp53q2hkz4hd2-python3-3.7.0.drv' failed with exit code 2
�[31;1merror:�[0m build of '/nix/store/1mpwdflyqkmkjxknpkzfp53q2hkz4hd2-python3-3.7.0.drv' failed

@veprbl veprbl changed the title Pr/py3 distutils patch maintenance python3 distutils patch maintenance Jul 3, 2018
@veprbl
Copy link
Member Author

veprbl commented Jul 3, 2018

The build failure in python37 is not related to this PR.

@vcunat
Copy link
Member

vcunat commented Jul 3, 2018

@GrahamcOfBorg build python36

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python36

Partial log (click to expand)

/nix/store/ihxxqhpdx3v06la2h02mgqkfvfhhymv3-python3-3.6.6

@vcunat
Copy link
Member

vcunat commented Jul 3, 2018

(from the report I wasn't sure of 3.6 status on darwin)

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python36

Partial log (click to expand)

/nix/store/dn3lkiwcd63r26cq9k5v3vpimn5dw8sl-python3-3.6.6

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python36

Partial log (click to expand)

/nix/store/9lfxy10hwpnip3xs6vx8xnjhwryx1mr8-python3-3.6.6

@vcunat vcunat merged commit ea08cf9 into NixOS:staging Jul 3, 2018
@vcunat
Copy link
Member

vcunat commented Jul 3, 2018

Oh, I see it was a trivial merge conflict, in a way.

@jtojnar jtojnar mentioned this pull request Dec 26, 2018
Closed
@veprbl veprbl deleted the pr/py3_distutils_patch_maintenance branch December 1, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@veprbl @GrahamcOfBorg @vcunat