Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Set#from_yaml #6310

Merged
merged 2 commits into from Dec 21, 2018
Merged

add Set#from_yaml #6310

merged 2 commits into from Dec 21, 2018

Conversation

kostya
Copy link
Contributor

@kostya kostya commented Jul 2, 2018 •
edited

Set#to_yaml already exists

@RX14
Copy link
Contributor

RX14 commented Jul 2, 2018

Please copy the Array.new code exactly.

@asterite
Copy link
Member

asterite commented Jul 2, 2018

Did you try Set with anchor and alias? I'm not sure it works, given that Set is a struct.

@j8r
Copy link
Contributor

j8r commented Dec 20, 2018

What's the state of this PR? Sounds like mergeable.

@RX14
Copy link
Contributor

RX14 commented Dec 20, 2018

Sorry, missed the updated PR.

@kostya
Copy link
Contributor Author

kostya commented Dec 20, 2018 •
edited

i not sure it would work with aliases, but it can be fixed separately

@RX14 RX14 added this to the 0.27.1 milestone Dec 21, 2018
@RX14 RX14 merged commit 46a3002 into crystal-lang:master Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asterite asterite asterite approved these changes

@RX14 RX14 RX14 approved these changes

Assignees
No one assigned
Labels
kind:feature topic:stdlib:serialization
Projects
None yet
Milestone
0.27.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kostya @RX14 @asterite @j8r