Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python: grpcio: 1.12.1 -> 1.13.0 #42854

Merged
merged 1 commit into from Jul 2, 2018
Merged

python: grpcio: 1.12.1 -> 1.13.0 #42854

merged 1 commit into from Jul 2, 2018

Conversation

numkem
Copy link
Contributor

@numkem numkem commented Jul 2, 2018

Motivation for this change

python: grpcio: 1.12.1 -> 1.13.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@numkem numkem requested a review from FRidh as a code owner July 2, 2018 02:17
@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.grpcio python3.pkgs.grpcio

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2.pkgs.grpcio, python3.pkgs.grpcio

Partial log (click to expand)

running build_ext
copying python_build/lib.linux-x86_64-3.6/grpc/_cython/cygrpc.cpython-36m-x86_64-linux-gnu.so -> src/python/grpcio/grpc/_cython
Found cython-generated files...

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/va906zlih29xv39ci302agc2c4lpswcl-python2.7-grpcio-1.13.0
/nix/store/yn5ncx58a1gqdx4rxm8ylzf979qxmvr2-python3.6-grpcio-1.13.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2.pkgs.grpcio, python3.pkgs.grpcio

Partial log (click to expand)

running build_ext
copying python_build/lib.linux-aarch64-3.6/grpc/_cython/cygrpc.cpython-36m-aarch64-linux-gnu.so -> src/python/grpcio/grpc/_cython
Found cython-generated files...

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/k4g0109qm8wkd8x73d0szmk6l5xp8nia-python2.7-grpcio-1.13.0
/nix/store/hd30zgs98hap81hrpx89218hh2accsmx-python3.6-grpcio-1.13.0

@dotlambda
Copy link
Member

dotlambda commented Jul 2, 2018 •
edited

This breaks tensorflow:
@GrahamcOfBorg build python2.pkgs.tensorflow

EDIT: Actually, it doesn't. Sorry for the noise.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: python2.pkgs.tensorflow

Partial log (click to expand)

unpacking sources
patching sources
updateAutotoolsGnuConfigScriptsPhase
configuring
building
installing
/build/dist /build
tensorflow-1.7.1-cp27-none-linux_x86_64.whl is not a supported wheel on this platform.
builder for '/nix/store/1wjqlfz3blga6al72hhfq12iksfz258n-python2.7-tensorflow-1.7.1.drv' failed with exit code 1
error: build of '/nix/store/1wjqlfz3blga6al72hhfq12iksfz258n-python2.7-tensorflow-1.7.1.drv' failed

@dotlambda dotlambda mentioned this pull request Jul 2, 2018
Closed
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2.pkgs.tensorflow

Partial log (click to expand)

strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/28958q2nf8q6wv8ss6wrxi0iyjx5s0i0-python2.7-tensorflow-1.7.1/lib  /nix/store/28958q2nf8q6wv8ss6wrxi0iyjx5s0i0-python2.7-tensorflow-1.7.1/bin
patching script interpreter paths in /nix/store/28958q2nf8q6wv8ss6wrxi0iyjx5s0i0-python2.7-tensorflow-1.7.1
checking for references to /build in /nix/store/28958q2nf8q6wv8ss6wrxi0iyjx5s0i0-python2.7-tensorflow-1.7.1...
wrapping `/nix/store/28958q2nf8q6wv8ss6wrxi0iyjx5s0i0-python2.7-tensorflow-1.7.1/bin/tensorboard'...
wrapping `/nix/store/28958q2nf8q6wv8ss6wrxi0iyjx5s0i0-python2.7-tensorflow-1.7.1/bin/saved_model_cli'...
wrapping `/nix/store/28958q2nf8q6wv8ss6wrxi0iyjx5s0i0-python2.7-tensorflow-1.7.1/bin/freeze_graph'...
wrapping `/nix/store/28958q2nf8q6wv8ss6wrxi0iyjx5s0i0-python2.7-tensorflow-1.7.1/bin/toco'...
wrapping `/nix/store/28958q2nf8q6wv8ss6wrxi0iyjx5s0i0-python2.7-tensorflow-1.7.1/bin/toco_from_protos'...
/nix/store/28958q2nf8q6wv8ss6wrxi0iyjx5s0i0-python2.7-tensorflow-1.7.1

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: python2.pkgs.tensorflow

Partial log (click to expand)

unpacking sources
patching sources
updateAutotoolsGnuConfigScriptsPhase
configuring
building
installing
/build/dist /build
tensorflow-1.7.1-cp27-none-linux_x86_64.whl is not a supported wheel on this platform.
builder for '/nix/store/1wjqlfz3blga6al72hhfq12iksfz258n-python2.7-tensorflow-1.7.1.drv' failed with exit code 1
error: build of '/nix/store/1wjqlfz3blga6al72hhfq12iksfz258n-python2.7-tensorflow-1.7.1.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2.pkgs.tensorflow

Partial log (click to expand)

strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/28958q2nf8q6wv8ss6wrxi0iyjx5s0i0-python2.7-tensorflow-1.7.1/lib  /nix/store/28958q2nf8q6wv8ss6wrxi0iyjx5s0i0-python2.7-tensorflow-1.7.1/bin
patching script interpreter paths in /nix/store/28958q2nf8q6wv8ss6wrxi0iyjx5s0i0-python2.7-tensorflow-1.7.1
checking for references to /build in /nix/store/28958q2nf8q6wv8ss6wrxi0iyjx5s0i0-python2.7-tensorflow-1.7.1...
wrapping `/nix/store/28958q2nf8q6wv8ss6wrxi0iyjx5s0i0-python2.7-tensorflow-1.7.1/bin/freeze_graph'...
wrapping `/nix/store/28958q2nf8q6wv8ss6wrxi0iyjx5s0i0-python2.7-tensorflow-1.7.1/bin/toco'...
wrapping `/nix/store/28958q2nf8q6wv8ss6wrxi0iyjx5s0i0-python2.7-tensorflow-1.7.1/bin/saved_model_cli'...
wrapping `/nix/store/28958q2nf8q6wv8ss6wrxi0iyjx5s0i0-python2.7-tensorflow-1.7.1/bin/tensorboard'...
wrapping `/nix/store/28958q2nf8q6wv8ss6wrxi0iyjx5s0i0-python2.7-tensorflow-1.7.1/bin/toco_from_protos'...
/nix/store/28958q2nf8q6wv8ss6wrxi0iyjx5s0i0-python2.7-tensorflow-1.7.1

@dotlambda
Copy link
Member

@GrahamcOfBorg eval

@dotlambda dotlambda merged commit b045d1f into NixOS:master Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@numkem @dotlambda @GrahamcOfBorg