Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.grpcio-tools: init at 1.13.0 #42939

Closed
wants to merge 1 commit into from
Closed

pythonPackages.grpcio-tools: init at 1.13.0 #42939

wants to merge 1 commit into from

Conversation

mmlb
Copy link
Contributor

@mmlb mmlb commented Jul 3, 2018

Motivation for this change

The seemingly only documented way of generating python grpc code is via the protoc python module, which is contained in this package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@mmlb mmlb requested a review from FRidh as a code owner July 3, 2018 20:14
@mmlb
Copy link
Contributor Author

mmlb commented Jul 3, 2018

I've coped most of this from grpcio, and I've kept @vanschelven as the maintainer (ping), let me know if I should change it.

dotlambda
dotlambda requested changes Jul 3, 2018
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a pythonPackages. prefix to your commit message.

pkgs/development/python-modules/grpcio-tools/default.nix Outdated

meta = with stdenv.lib; {
description = "Package for gRPC Python tools";
license = lib.licenses.bsd3;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops. I checked and grpcio is also apache2. Will open separate pr for it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

pkgs/development/python-modules/grpcio-tools/default.nix Outdated
propagatedBuildInputs = [ six protobuf grpc grpcio ];

meta = with stdenv.lib; {
description = "Package for gRPC Python tools";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Protobuf code generator for gRPC"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.grpcio-tools python3.pkgs.grpcio-tools

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2.pkgs.grpcio-tools, python3.pkgs.grpcio-tools

Partial log (click to expand)

Ran 0 tests in 0.000s

OK

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/zr9lwgs68hxadpgs6grba6rh3iikavfa-python2.7-grpcio-tools-1.13.0
/nix/store/v2yx61pnwj23xjvpgfm1mysjqqgirayp-python3.6-grpcio-tools-1.13.0

@dotlambda dotlambda changed the title grpcio-tools: init at 1.13.0 pythonPackages.grpcio-tools: init at 1.13.0 Jul 3, 2018
@dotlambda
Copy link
Member

Ran 0 tests in 0.000s

Please provide an appropriate checkPhase.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2.pkgs.grpcio-tools, python3.pkgs.grpcio-tools

Partial log (click to expand)

writing manifest file 'grpcio_tools.egg-info/SOURCES.txt'
running build_ext
copying build/lib.linux-aarch64-3.6/grpc_tools/_protoc_compiler.cpython-36m-aarch64-linux-gnu.so -> grpc_tools

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/2h9wpkl4jss3hh1d516fjrmd2ph6yvry-python2.7-grpcio-tools-1.13.0
/nix/store/7hl2y4rij2frsq3imnjizgph2frvr9s8-python3.6-grpcio-tools-1.13.0

@mmlb
Copy link
Contributor Author

mmlb commented Jul 3, 2018

@dotlambda I don't think I can? There does not seem to be any python tests in the package, any suggestions?

@mmlb mmlb mentioned this pull request Jul 3, 2018
Merged
9 tasks
@dotlambda
Copy link
Member

In that case, please set doCheck = false and add a comment that there are no tests.

@mmlb mmlb closed this Jul 3, 2018
@mmlb mmlb deleted the python-grpcio-tools branch July 3, 2018 21:11
@mmlb mmlb restored the python-grpcio-tools branch July 3, 2018 21:13
@dotlambda
Copy link
Member

Why did you close?

@mmlb
Copy link
Contributor Author

mmlb commented Jul 4, 2018

@dotlambda I was cleaning up branches on my fork and mistakenly deleted this branch... and GH closed. Will open a new one up.

@mmlb
Copy link
Contributor Author

mmlb commented Jul 4, 2018

@dotlambda seems like admin/owner/authorized member can reopen the PR, can you do so?

@dotlambda
Copy link
Member

No, I think you can't reopen it after altering the branch.

@mmlb
Copy link
Contributor Author

mmlb commented Jul 4, 2018

oic, well new PR coming in a moment.

@mmlb mmlb mentioned this pull request Jul 4, 2018
Merged
9 tasks
@vanschelven
Copy link
Contributor

ping acknowledged; I'm fine with being the maintainer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mmlb @dotlambda @GrahamcOfBorg @vanschelven