Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

androidndk: cleanups #42397

Merged
merged 4 commits into from Jun 22, 2018
Merged

androidndk: cleanups #42397

merged 4 commits into from Jun 22, 2018

Conversation

matthewbauer
Copy link
Member

Motivation for this change

These are some more android fixups. Hopefully these are all good changes.

/cc @bkchr

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@matthewbauer
androidndk: use unzip
a7fc8ad 
This is a free version and preferred to 7zip.
@matthewbauer
androidndk: reduce output sizw
054656a 
Fixes NixOS#41704
@matthewbauer matthewbauer changed the title androidndk: fixup androidndk: cleanups Jun 22, 2018
Ericson2314
Ericson2314 reviewed Jun 22, 2018
View reviewed changes
Copy link
Member

@Ericson2314 Ericson2314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventually it would be nice to use multiple outputs to get around the size limits, but @edolstra says hydra/nix sums it, so this is good for now.

@Ericson2314 Ericson2314 merged commit bbef861 into NixOS:master Jun 22, 2018
@Ericson2314 Ericson2314 deleted the more-android-fixes branch June 22, 2018 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Ericson2314 left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@matthewbauer @Ericson2314 @bkchr @GrahamcOfBorg