xcode: add xcodeVer to system #42399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ericson2314
approved these changes
Jun 22, 2018
|
Ooooo! \o/ |
matthewbauer
commented
Jun 23, 2018
| xcode_8_1 = requireXcode "8.1" "18xjvfipwzia66gm3r9p770xdd4r375vak7chw5vgqnv9yyjiq2n"; | ||
| xcode_8_2 = requireXcode "8.2" "13nd1zsfqcp9hwp15hndr0rsbb8rgprrz7zr2ablj4697qca06m2"; | ||
| xcode_9_1 = requireXcode "9.1" "0ab1403wy84ys3yn26fj78cazhpnslmh3nzzp1wxib3mr1afjvic"; | ||
| xcode_9_2 = requireXcode "9.2" "1bgfgdp266cbbqf2axcflz92frzvhi0qw0jdkcw6r85kdpc8dj4c"; | ||
| xcode_9_4 = requireXcode "9.4" "6731381785075602a52489f7ea47ece8f6daf225007ba3ffae1fd59b1c0b5f01"; | ||
| xcode = xcode_9_4; | ||
| } | ||
| xcode = self."xcode_${lib.replaceStrings ["."] ["_"] (if hostPlatform.useiOSPrebuilt then hostPlatform.xcodeVer else "9.4")}"; |
There was a problem hiding this comment.
This breaks when evaluating stdenv/cross/default.nix. You cannot rely on hostPlatform there - we need to use crossSystem. /cc @Ericson2314
There was a problem hiding this comment.
Hmm? That's really weird and sounds like a bug in the cross stdenv.
There was a problem hiding this comment.
I’ll try to debug what’s happening but I think it’s because hostPlatform is not iOS yet. Does that make sense?
This version number controls which xcode version to use when building cross to iOS.
matthewbauer
force-pushed
the
xcodever-in-system
branch
from
0c6824a
to
9b0b31d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version number controls which xcode version to use when building
cross to iOS.
The default "darwin.xcode" attribute can be referred to to find the "right" xcode to use for your system. It will default to 9.4 (latest) on non-prebuilt targets.
/cc @alexfmpe