Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

freeradius : added service to module-list #42394

Merged
merged 1 commit into from Jun 29, 2018
Merged

freeradius : added service to module-list #42394

merged 1 commit into from Jun 29, 2018

Conversation

netixx
Copy link
Contributor

@netixx netixx commented Jun 22, 2018

The freeradius service was merged with #34587
but the module was not added to module-list.

Motivation for this change

This commit fixes that and enables the use of
services.freeradius in nixos configuration.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@netixx
freeradius : added service to module-list
4ea4073 
The freeradius service was merged with NixOS#34587
but the module was not added to module-list.

This commit fixes that and enables the use of
services.freeradius in nixos configuration.
@matthewbauer matthewbauer merged commit e0cd8fc into NixOS:master Jun 29, 2018
@netixx
Copy link
Contributor Author

netixx commented Jul 3, 2018

Thank you ! (and sorry for forgetting this in the first place...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@netixx @matthewbauer @GrahamcOfBorg