Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libtorrentRasterbar: use boost166 (fix build) #42401

Closed
wants to merge 1 commit into from
Closed

libtorrentRasterbar: use boost166 (fix build) #42401

wants to merge 1 commit into from

Conversation

worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Jun 22, 2018 •
edited

Motivation for this change

libtorrentRasterbar-1.1.7 won't build with boost167.
Fixes #42396

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@andir
Copy link
Member

andir commented Jun 22, 2018

Have you considered if applying an patch for the newer verison would be better/similar?

Upstream has a patch for this exact issue: arvidn/libtorrent@64d6b49

@worldofpeace
Copy link
Contributor Author

@andir
Thanks!
Yeah that would be better.

@worldofpeace worldofpeace mentioned this pull request Jun 23, 2018
Merged
9 tasks
@worldofpeace worldofpeace reopened this Jun 23, 2018
@worldofpeace worldofpeace deleted the patch-1 branch March 18, 2019 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: merge conflict 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@worldofpeace @andir @GrahamcOfBorg