Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

curl: disable default CA bundle #42415

Merged
merged 1 commit into from Jun 24, 2018
Merged

curl: disable default CA bundle #42415

merged 1 commit into from Jun 24, 2018

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Jun 23, 2018

Motivation for this change

Without this curl might detect /etc/ssl/cert.pem at build time on macOS,
causing curl to ignore NIX_SSL_CERT_FILE.

Tested curl with both NIX_SSL_CERT_FILE and the fallback to /nix/var/nix/profiles/default/etc/ssl/certs/ca-bundle.crt when it's not defined.

Fixes #42317

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@LnL7
curl: disable default CA bundle
288939c 
Without this curl might detect /etc/ssl/cert.pem at build time on macOS,
causing curl to ignore NIX_SSL_CERT_FILE.

Fixes NixOS#42317
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: curl

Partial log (click to expand)

patching script interpreter paths in /nix/store/w5cbwngadjv4l06z42r569jqmqw0bjin-curl-7.60.0-man
checking for references to /build in /nix/store/w5cbwngadjv4l06z42r569jqmqw0bjin-curl-7.60.0-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/3515syg5aidgl1krph715lqa7nl7qyaw-curl-7.60.0-devdoc
gzipping man pages under /nix/store/3515syg5aidgl1krph715lqa7nl7qyaw-curl-7.60.0-devdoc/share/man/
patching script interpreter paths in /nix/store/3515syg5aidgl1krph715lqa7nl7qyaw-curl-7.60.0-devdoc
checking for references to /build in /nix/store/3515syg5aidgl1krph715lqa7nl7qyaw-curl-7.60.0-devdoc...
shrinking RPATHs of ELF executables and libraries in /nix/store/2bl4kq3h5b4ivdas762jdyk5vvmairdn-curl-7.60.0-debug
patching script interpreter paths in /nix/store/2bl4kq3h5b4ivdas762jdyk5vvmairdn-curl-7.60.0-debug
checking for references to /build in /nix/store/2bl4kq3h5b4ivdas762jdyk5vvmairdn-curl-7.60.0-debug...
/nix/store/9vbr9jzwm8953p3qj8jxc2cvhyn48cab-curl-7.60.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: curl

Partial log (click to expand)

strip is /nix/store/7ddbq63v97nk8gkbf7gcsfmby37h6gbl-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/g186ykbb7ysy47qgw8k30bb1xpj6lrm7-curl-7.60.0/lib
patching script interpreter paths in /nix/store/g186ykbb7ysy47qgw8k30bb1xpj6lrm7-curl-7.60.0
gzipping man pages under /nix/store/mwy8hcz1ii80ikvj9mlkqfhbcvjdp5kw-curl-7.60.0-man/share/man/
strip is /nix/store/7ddbq63v97nk8gkbf7gcsfmby37h6gbl-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/mwy8hcz1ii80ikvj9mlkqfhbcvjdp5kw-curl-7.60.0-man
gzipping man pages under /nix/store/mhyamd9z7pfg4laj43c8hw86jjzf1a7f-curl-7.60.0-devdoc/share/man/
strip is /nix/store/7ddbq63v97nk8gkbf7gcsfmby37h6gbl-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/mhyamd9z7pfg4laj43c8hw86jjzf1a7f-curl-7.60.0-devdoc
/nix/store/i1d7w2apzaqgadapm33ll9l08zqpzqq0-curl-7.60.0-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: curl

Partial log (click to expand)

patching script interpreter paths in /nix/store/543y4dg99m4wk6xs9n224ls57mkg2qi1-curl-7.60.0-man
checking for references to /build in /nix/store/543y4dg99m4wk6xs9n224ls57mkg2qi1-curl-7.60.0-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/ws3rbfq2qgi7m088qrgcazdgw7amnab1-curl-7.60.0-devdoc
gzipping man pages under /nix/store/ws3rbfq2qgi7m088qrgcazdgw7amnab1-curl-7.60.0-devdoc/share/man/
patching script interpreter paths in /nix/store/ws3rbfq2qgi7m088qrgcazdgw7amnab1-curl-7.60.0-devdoc
checking for references to /build in /nix/store/ws3rbfq2qgi7m088qrgcazdgw7amnab1-curl-7.60.0-devdoc...
shrinking RPATHs of ELF executables and libraries in /nix/store/iidk9yi0bf4msbfvsbxni5yf7w6yjshs-curl-7.60.0-debug
patching script interpreter paths in /nix/store/iidk9yi0bf4msbfvsbxni5yf7w6yjshs-curl-7.60.0-debug
checking for references to /build in /nix/store/iidk9yi0bf4msbfvsbxni5yf7w6yjshs-curl-7.60.0-debug...
/nix/store/vxygcc8idksrjhpbdhvvsrjrxyfnkl83-curl-7.60.0-bin

@LnL7 LnL7 changed the base branch from master to staging June 23, 2018 17:06
@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: curl

Partial log (click to expand)

/nix/store/i1d7w2apzaqgadapm33ll9l08zqpzqq0-curl-7.60.0-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: curl

Partial log (click to expand)

/nix/store/vxygcc8idksrjhpbdhvvsrjrxyfnkl83-curl-7.60.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: curl

Partial log (click to expand)

patching script interpreter paths in /nix/store/w5cbwngadjv4l06z42r569jqmqw0bjin-curl-7.60.0-man
checking for references to /build in /nix/store/w5cbwngadjv4l06z42r569jqmqw0bjin-curl-7.60.0-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/3515syg5aidgl1krph715lqa7nl7qyaw-curl-7.60.0-devdoc
gzipping man pages under /nix/store/3515syg5aidgl1krph715lqa7nl7qyaw-curl-7.60.0-devdoc/share/man/
patching script interpreter paths in /nix/store/3515syg5aidgl1krph715lqa7nl7qyaw-curl-7.60.0-devdoc
checking for references to /build in /nix/store/3515syg5aidgl1krph715lqa7nl7qyaw-curl-7.60.0-devdoc...
shrinking RPATHs of ELF executables and libraries in /nix/store/2bl4kq3h5b4ivdas762jdyk5vvmairdn-curl-7.60.0-debug
patching script interpreter paths in /nix/store/2bl4kq3h5b4ivdas762jdyk5vvmairdn-curl-7.60.0-debug
checking for references to /build in /nix/store/2bl4kq3h5b4ivdas762jdyk5vvmairdn-curl-7.60.0-debug...
/nix/store/9vbr9jzwm8953p3qj8jxc2cvhyn48cab-curl-7.60.0-bin

@xeji xeji merged commit 6806fb5 into NixOS:staging Jun 24, 2018
@LnL7 LnL7 deleted the darwin-curl-ca branch June 25, 2018 09:01
@yurrriq yurrriq mentioned this pull request Feb 10, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LnL7 @GrahamcOfBorg @xeji