Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keepassxc: fix build with qt 5.11 #42381

Merged
merged 1 commit into from Jun 24, 2018
Merged

keepassxc: fix build with qt 5.11 #42381

merged 1 commit into from Jun 24, 2018

Conversation

averelld
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Jun 24, 2018

@GrahamcOfBorg build keepassxc

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: keepassxc

Partial log (click to expand)

shrinking /nix/store/9q3ffr5lyakf23hbvrrh4hm6sy5wsksh-keepassxc-2.3.3/bin/keepassxc-proxy
shrinking /nix/store/9q3ffr5lyakf23hbvrrh4hm6sy5wsksh-keepassxc-2.3.3/bin/keepassxc-cli
shrinking /nix/store/9q3ffr5lyakf23hbvrrh4hm6sy5wsksh-keepassxc-2.3.3/lib/keepassxc/libkeepassx-autotype-xcb.so
gzipping man pages under /nix/store/9q3ffr5lyakf23hbvrrh4hm6sy5wsksh-keepassxc-2.3.3/share/man/
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/9q3ffr5lyakf23hbvrrh4hm6sy5wsksh-keepassxc-2.3.3/lib  /nix/store/9q3ffr5lyakf23hbvrrh4hm6sy5wsksh-keepassxc-2.3.3/bin
patching script interpreter paths in /nix/store/9q3ffr5lyakf23hbvrrh4hm6sy5wsksh-keepassxc-2.3.3
checking for references to /build in /nix/store/9q3ffr5lyakf23hbvrrh4hm6sy5wsksh-keepassxc-2.3.3...
postPatchMkspecs
postPatchMkspecs

@xeji xeji mentioned this pull request Jun 24, 2018
Closed
5 tasks
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: keepassxc

Partial log (click to expand)

shrinking /nix/store/98gxl8sw1y9vqi6cjr0jnb0j72yq9c1k-keepassxc-2.3.3/bin/keepassxc-cli
shrinking /nix/store/98gxl8sw1y9vqi6cjr0jnb0j72yq9c1k-keepassxc-2.3.3/bin/keepassxc-proxy
shrinking /nix/store/98gxl8sw1y9vqi6cjr0jnb0j72yq9c1k-keepassxc-2.3.3/bin/keepassxc
gzipping man pages under /nix/store/98gxl8sw1y9vqi6cjr0jnb0j72yq9c1k-keepassxc-2.3.3/share/man/
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/98gxl8sw1y9vqi6cjr0jnb0j72yq9c1k-keepassxc-2.3.3/lib  /nix/store/98gxl8sw1y9vqi6cjr0jnb0j72yq9c1k-keepassxc-2.3.3/bin
patching script interpreter paths in /nix/store/98gxl8sw1y9vqi6cjr0jnb0j72yq9c1k-keepassxc-2.3.3
checking for references to /build in /nix/store/98gxl8sw1y9vqi6cjr0jnb0j72yq9c1k-keepassxc-2.3.3...
postPatchMkspecs
postPatchMkspecs

@xeji xeji mentioned this pull request Jun 24, 2018
Closed
9 tasks
@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: keepassxc

Partial log (click to expand)

-- Installing: /nix/store/zvypkczbyp29vp1j1cy93dfnq8sb38ja-keepassxc-2.3.3/Applications/KeePassXC.app/Contents/Resources/translations/keepassx_uk.qm
-- Installing: /nix/store/zvypkczbyp29vp1j1cy93dfnq8sb38ja-keepassxc-2.3.3/Applications/KeePassXC.app/Contents/Resources/translations/keepassx_zh_CN.qm
-- Installing: /nix/store/zvypkczbyp29vp1j1cy93dfnq8sb38ja-keepassxc-2.3.3/Applications/KeePassXC.app/Contents/Resources/translations/keepassx_zh_TW.qm
post-installation fixup
gzipping man pages under /nix/store/zvypkczbyp29vp1j1cy93dfnq8sb38ja-keepassxc-2.3.3/share/man/
strip is /nix/store/7ddbq63v97nk8gkbf7gcsfmby37h6gbl-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/zvypkczbyp29vp1j1cy93dfnq8sb38ja-keepassxc-2.3.3/bin
patching script interpreter paths in /nix/store/zvypkczbyp29vp1j1cy93dfnq8sb38ja-keepassxc-2.3.3
postPatchMkspecs
postPatchMkspecs

@xeji xeji merged commit 32b2f28 into NixOS:master Jun 24, 2018
@averelld averelld deleted the keepassx-qt511-fixes branch June 24, 2018 21:30
matejc pushed a commit to matejc/nixpkgs that referenced this pull request Jun 25, 2018
@averelld @matejc
keepassxc: fix build with qt 5.11 (NixOS#42381)
5d179cf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@averelld @xeji @GrahamcOfBorg