Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x2goclient: fix build with qt 5.11 #42382

Merged
merged 2 commits into from Jun 24, 2018
Merged

x2goclient: fix build with qt 5.11 #42382

merged 2 commits into from Jun 24, 2018

Conversation

averelld
Copy link
Contributor

@averelld averelld commented Jun 22, 2018 •
edited

Motivation for this change

Fixes #42298. Also upgrade to latest version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Jun 24, 2018

@GrahamcOfBorg eval

@xeji
Copy link
Contributor

xeji commented Jun 24, 2018

@GrahamcOfBorg build x2goclient

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: x2goclient

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/wij93mpj2qdvk75pp77vwcjzimskzyg3-x2goclient-4.1.2.0
shrinking /nix/store/wij93mpj2qdvk75pp77vwcjzimskzyg3-x2goclient-4.1.2.0/bin/.x2goclient-wrapped
gzipping man pages under /nix/store/wij93mpj2qdvk75pp77vwcjzimskzyg3-x2goclient-4.1.2.0/share/man/
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/wij93mpj2qdvk75pp77vwcjzimskzyg3-x2goclient-4.1.2.0/bin
patching script interpreter paths in /nix/store/wij93mpj2qdvk75pp77vwcjzimskzyg3-x2goclient-4.1.2.0
checking for references to /build in /nix/store/wij93mpj2qdvk75pp77vwcjzimskzyg3-x2goclient-4.1.2.0...
postPatchMkspecs
/nix/store/wij93mpj2qdvk75pp77vwcjzimskzyg3-x2goclient-4.1.2.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: x2goclient

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/jc1a11c9a8sa57aj15hyn33gwk1izg6d-x2goclient-4.1.2.0
shrinking /nix/store/jc1a11c9a8sa57aj15hyn33gwk1izg6d-x2goclient-4.1.2.0/bin/.x2goclient-wrapped
gzipping man pages under /nix/store/jc1a11c9a8sa57aj15hyn33gwk1izg6d-x2goclient-4.1.2.0/share/man/
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/jc1a11c9a8sa57aj15hyn33gwk1izg6d-x2goclient-4.1.2.0/bin
patching script interpreter paths in /nix/store/jc1a11c9a8sa57aj15hyn33gwk1izg6d-x2goclient-4.1.2.0
checking for references to /build in /nix/store/jc1a11c9a8sa57aj15hyn33gwk1izg6d-x2goclient-4.1.2.0...
postPatchMkspecs
/nix/store/jc1a11c9a8sa57aj15hyn33gwk1izg6d-x2goclient-4.1.2.0

@xeji xeji merged commit 7d7b2de into NixOS:master Jun 24, 2018
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: x2goclient

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@averelld averelld deleted the x2goclient-qt511-fixes branch June 24, 2018 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@averelld @xeji @GrahamcOfBorg