treewide: make added libs optional #42411
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some linker configurtions have issues when you give it a library that it’s not expecting. This seems to happen most often in cross compilation for some reason. We now add a global option to disable this behavior: $dontAddLibs When set to non-empty, this will prevent Nix setup hooks from adding "compatibility" libraries. Because certain libc’s will not need these compatiblity libraries, we have two other variables that control adding libintl & libiconv. $dontAddLibiconv $dontAddLibintl These will be set when compiling with Glibc & Musl which already have their own version bundled. You can also set them manually in your derivation to disable the behavior.
matthewbauer
force-pushed
the
optional-added-libs
branch
from
4378769
to
80bfccd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some linker configurtions have issues when you give it a library that
it’s not expecting. This seems to happen most often in cross
compilation for some reason. We now add a global option to disable
this behavior:
When set to non-empty, this will prevent Nix setup hooks from adding
"compatibility" libraries. Because certain libc’s will not need these
compatiblity libraries, we have two other variables that control
adding libintl & libiconv.
These will be set when compiling with Glibc & Musl which already have
their own version bundled. You can also set them manually in your
derivation to disable the behavior.
Motivation for this change
This was created in response to issues I had with libiconv & the Android NDK in #42333.