Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/screen: add pkgs.screen to the system closure #42410

Merged
merged 1 commit into from Jun 23, 2018
Merged

nixos/screen: add pkgs.screen to the system closure #42410

merged 1 commit into from Jun 23, 2018

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Jun 23, 2018 •
edited

Motivation for this change

When enabling any software in programs.* the package should be available globally. Just adding config files seems fairly counterintuitive.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

andir
andir approved these changes Jun 23, 2018
View reviewed changes
Copy link
Member

@andir andir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 👍

This should probably have done a long time ago.

One small (optional?) nitpick:

Since this "issue" was introduced in 2013 and people that use the programs.screen option must have added screen to their system package set manually. Having a note in the changelog about this would be nice so people can cleanup on the next update/release when they (should) go through the changes listed there.

@Ma27
Copy link
Member Author

Ma27 commented Jun 23, 2018

@andir you're absolutely right! I added a new paragraph in Other notable changes and built the docs locally for testing :)

@Ma27 Ma27 mentioned this pull request Jun 23, 2018
Merged
9 tasks
@FRidh FRidh merged commit 904114f into NixOS:master Jun 23, 2018
@Ma27 Ma27 deleted the improve-screen-module branch June 23, 2018 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andir andir andir approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: changelog 8.has: documentation 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ma27 @andir @FRidh @GrahamcOfBorg