feedgnuplot: init at 1.49 #42668
Merged
feedgnuplot: init at 1.49 #42668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build feedgnuplot |
|
Success on x86_64-linux (full log) Attempted: feedgnuplot Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: feedgnuplot Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: feedgnuplot Partial log (click to expand)
|
|
Looks like this doesn't really run any tests because of a gnuplot version mismatch: So I suggest you either try get the tests to run, or disable them with a comment explaining why. |
|
I tried to run the plot tests but they fail because they check if rendered outputs are precisely equal to those expected using gnuplot 4.6.4. gnuplot 5's rendering slightly changed. That's why the tests are skipped.
Looking at the homepage and manual, they do not mention about gnuplot's version requirement. Actually it runs fine with gnuplot 5 in my environment. |
In this situation I would suggest to disable tests with a comment explaning why. This saves other people a little time to understand what's going on. |
|
Got it. Disabled tests. |
|
Thank you. |
|
Success on x86_64-linux (full log) Attempted: feedgnuplot Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: feedgnuplot Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: feedgnuplot Partial log (click to expand)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
It is a nice tool for doing data-science things in command line.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)