Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bfs 1.2.2 #42662

Merged
merged 1 commit into from Jun 27, 2018
Merged

bfs 1.2.2 #42662

merged 1 commit into from Jun 27, 2018

Conversation

yesbox
Copy link
Contributor

@yesbox yesbox commented Jun 27, 2018

Update to latest version.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Jun 27, 2018

@GrahamcOfBorg build bfs

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: bfs

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: bfs

Partial log (click to expand)

install -m644 bfs.1 /nix/store/ihg1xxc4ki8dr6k94l20ymwwlcdpr8zg-bfs-1.2.2/share/man/man1/bfs.1
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ihg1xxc4ki8dr6k94l20ymwwlcdpr8zg-bfs-1.2.2
shrinking /nix/store/ihg1xxc4ki8dr6k94l20ymwwlcdpr8zg-bfs-1.2.2/bin/bfs
gzipping man pages under /nix/store/ihg1xxc4ki8dr6k94l20ymwwlcdpr8zg-bfs-1.2.2/share/man/
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ihg1xxc4ki8dr6k94l20ymwwlcdpr8zg-bfs-1.2.2/bin
patching script interpreter paths in /nix/store/ihg1xxc4ki8dr6k94l20ymwwlcdpr8zg-bfs-1.2.2
checking for references to /build in /nix/store/ihg1xxc4ki8dr6k94l20ymwwlcdpr8zg-bfs-1.2.2...
/nix/store/ihg1xxc4ki8dr6k94l20ymwwlcdpr8zg-bfs-1.2.2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: bfs

Partial log (click to expand)

mkdir -p /nix/store/71vfbaa8a9xjjpv7vch1sri1mixsk74w-bfs-1.2.2/share/man/man1
install -m644 bfs.1 /nix/store/71vfbaa8a9xjjpv7vch1sri1mixsk74w-bfs-1.2.2/share/man/man1/bfs.1
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/71vfbaa8a9xjjpv7vch1sri1mixsk74w-bfs-1.2.2
shrinking /nix/store/71vfbaa8a9xjjpv7vch1sri1mixsk74w-bfs-1.2.2/bin/bfs
gzipping man pages under /nix/store/71vfbaa8a9xjjpv7vch1sri1mixsk74w-bfs-1.2.2/share/man/
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/71vfbaa8a9xjjpv7vch1sri1mixsk74w-bfs-1.2.2/bin
patching script interpreter paths in /nix/store/71vfbaa8a9xjjpv7vch1sri1mixsk74w-bfs-1.2.2
checking for references to /build in /nix/store/71vfbaa8a9xjjpv7vch1sri1mixsk74w-bfs-1.2.2...

@xeji xeji merged commit 4a59bc4 into NixOS:master Jun 27, 2018
@yesbox yesbox deleted the bfs_1.2.2 branch June 27, 2018 19:24
tavianator
tavianator reviewed Jun 28, 2018
View reviewed changes
pkgs/tools/system/bfs/default.nix

src = fetchFromGitHub {
repo = "bfs";
owner = "tavianator";
rev = version;
sha256 = "1dgc31l5d20i0v78c51xga4lr78b5x8dz6yzsvbhlgs0abi0nynx";
sha256 = "0a7zsipvndvg1kp2i35jrg9y9kncj7i6mp36dhpj8zjmkm5d5b8g";
};

# Disable fstype test, tries to read /etc/mtab
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably not needed anymore

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. What isn't needed? I don't follow.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabling the fstype test

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can give it a try and delete the patch. If the tests work in a sandbox it's fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tried building it locally with all tests enabled. It works fine with the latest version. I'll try to remember removing it next time I update if no one else wants to. Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The next version was merged and there is now an open PR here #43810.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tavianator tavianator tavianator left review comments

@xeji xeji xeji left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yesbox @xeji @GrahamcOfBorg @tavianator