Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dolphinEmuMaster: 2018-06-22 -> 2018-06-27 #42686

Closed
wants to merge 5 commits into from
Closed

dolphinEmuMaster: 2018-06-22 -> 2018-06-27 #42686

wants to merge 5 commits into from

Conversation

Chiiruno
Copy link
Contributor

@Chiiruno Chiiruno commented Jun 27, 2018 •
edited

Motivation for this change

Version bump.
Change default GUI from wxWidgets to Qt.
screenshot_20180627_182246

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Chiiruno
Copy link
Contributor Author

cc @MP2E

@Chiiruno
Copy link
Contributor Author

Chiiruno commented Jun 28, 2018 •
edited

As a side note, I ran nix path-info -S, but I didn't really get any useful info.
Exactly where am I supposed to run this?

@Chiiruno
Copy link
Contributor Author

wxWidgets was removed in dolphin-emu/dolphin#6819

@Chiiruno
Copy link
Contributor Author

I also did some restructuring because wxWidgets was removed, as well as checking the dependencies upstream.

@MP2E
Copy link

MP2E commented Jul 2, 2018

Looks great, as usual! Good to see that they moved quickly in making the qt frontend the default, that cleans up the expression quite a bit.

Squashed the changes into 1 commit and merged as of 8b312db

@MP2E MP2E closed this Jul 2, 2018
@Chiiruno Chiiruno deleted the dev/dolphin-emu branch July 3, 2018 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Chiiruno @MP2E @GrahamcOfBorg @Madouura