Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmrt, vaapi-intel-hybrid, vaapiIntel: init at 1.0.6, init at 1.0.2, add enableHybridCodec option #42673

Merged
merged 3 commits into from Aug 25, 2018
Merged

cmrt, vaapi-intel-hybrid, vaapiIntel: init at 1.0.6, init at 1.0.2, add enableHybridCodec option #42673

merged 3 commits into from Aug 25, 2018

Conversation

tadfisher
Copy link
Contributor

Motivation for this change

Adds the Intel hybrid VAAPI driver to enable partially-accelerated VP9 decoding on Westmere through Skylake architectures.

Adds a flag to enable the hybrid driver to vaapiIntel, as the benefits are hardware-dependent.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@tadfisher
Copy link
Contributor Author

cc maintainers: @garbas

@tadfisher
Copy link
Contributor Author

@GrahamcOfBorg build cmrt vaapi-intel-hybrid vaapiIntel

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: cmrt, vaapi-intel-hybrid

The following builds were skipped because they don't evaluate on aarch64-linux: vaapiIntel

Partial log (click to expand)

make[3]: *** [Makefile:851: libcmrt_la-debugger.lo] Error 1
make[3]: Leaving directory '/build/cmrt-1.0.6/src'
make[2]: *** [Makefile:1076: all-recursive] Error 1
make[2]: Leaving directory '/build/cmrt-1.0.6/src'
make[1]: *** [Makefile:591: all] Error 2
make[1]: Leaving directory '/build/cmrt-1.0.6/src'
make: *** [Makefile:433: all-recursive] Error 1
builder for '/nix/store/v5a3f7pnfhc4bj7wraz0gdls92842dwv-cmrt-1.0.6.drv' failed with exit code 2
cannot build derivation '/nix/store/kkr0nz8jj6cb7g9fmg26kvaaizygahxz-intel-hybrid-driver-1.0.2.drv': 1 dependencies couldn't be built
error: build of '/nix/store/kkr0nz8jj6cb7g9fmg26kvaaizygahxz-intel-hybrid-driver-1.0.2.drv', '/nix/store/v5a3f7pnfhc4bj7wraz0gdls92842dwv-cmrt-1.0.6.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: cmrt, vaapi-intel-hybrid, vaapiIntel

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/z926n3f2nlnbysdihzsl4cpx1c0w5x2w-intel-hybrid-driver-1.0.2
shrinking /nix/store/z926n3f2nlnbysdihzsl4cpx1c0w5x2w-intel-hybrid-driver-1.0.2/lib/dri/hybrid_drv_video.so
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/z926n3f2nlnbysdihzsl4cpx1c0w5x2w-intel-hybrid-driver-1.0.2/lib
patching script interpreter paths in /nix/store/z926n3f2nlnbysdihzsl4cpx1c0w5x2w-intel-hybrid-driver-1.0.2
checking for references to /build in /nix/store/z926n3f2nlnbysdihzsl4cpx1c0w5x2w-intel-hybrid-driver-1.0.2...
/nix/store/qd8vrrsp14lqlydsmh0qnapsik8vlkdx-cmrt-1.0.6
/nix/store/z926n3f2nlnbysdihzsl4cpx1c0w5x2w-intel-hybrid-driver-1.0.2
/nix/store/3x9pcnv2nxipiigan0pk01f7khv6vnwj-intel-vaapi-driver-2.1.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: cmrt, vaapi-intel-hybrid, vaapiIntel

Partial log (click to expand)

/nix/store/qd8vrrsp14lqlydsmh0qnapsik8vlkdx-cmrt-1.0.6
/nix/store/z926n3f2nlnbysdihzsl4cpx1c0w5x2w-intel-hybrid-driver-1.0.2
/nix/store/3x9pcnv2nxipiigan0pk01f7khv6vnwj-intel-vaapi-driver-2.1.0

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: cmrt, vaapi-intel-hybrid

The following builds were skipped because they don't evaluate on aarch64-linux: vaapiIntel

Partial log (click to expand)

make[3]: *** [Makefile:851: libcmrt_la-debugger.lo] Error 1
make[3]: Leaving directory '/build/cmrt-1.0.6/src'
make[2]: *** [Makefile:1076: all-recursive] Error 1
make[2]: Leaving directory '/build/cmrt-1.0.6/src'
make[1]: *** [Makefile:591: all] Error 2
make[1]: Leaving directory '/build/cmrt-1.0.6/src'
make: *** [Makefile:433: all-recursive] Error 1
builder for '/nix/store/v5a3f7pnfhc4bj7wraz0gdls92842dwv-cmrt-1.0.6.drv' failed with exit code 2
cannot build derivation '/nix/store/kkr0nz8jj6cb7g9fmg26kvaaizygahxz-intel-hybrid-driver-1.0.2.drv': 1 dependencies couldn't be built
error: build of '/nix/store/kkr0nz8jj6cb7g9fmg26kvaaizygahxz-intel-hybrid-driver-1.0.2.drv', '/nix/store/v5a3f7pnfhc4bj7wraz0gdls92842dwv-cmrt-1.0.6.drv' failed

@xeji xeji merged commit 9fcffb5 into NixOS:master Aug 25, 2018
@Mic92
Copy link
Member

Mic92 commented Dec 11, 2018

Is there any performance disadvantage for newer CPUs if we enable this everywhere?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tadfisher @GrahamcOfBorg @Mic92 @matthewbauer @xeji