haskellPackages.callCabal2nix: accept extraCabal2nixOptions argument #42658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 2, 2018
Open
kirelagin
reviewed
Jul 2, 2018
| in overrideCabal (callPackageKeepDeriver expr args) (orig: { | ||
| } // haskellSrc2nixArgs); | ||
| callPackageArgs = filterAttrs (name: v: name != "extraCabal2nixOptions") args; | ||
| haskellSrc2nixArgs = filterAttrs (name: v: name == "extraCabal2nixOptions") args; |
There was a problem hiding this comment.
You could just inherit it in the definition of expr.
There was a problem hiding this comment.
Yes, I have thought of that, but we'd have to duplicate the definition of the default argument. I think duplication of definitions is worse than a slightly awkward but clear expression.
9 tasks
|
Closing because #44424 was merged to implemented this differently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This should resolve #42051 and #42550
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)