libvmi: init at 0.12 #42683

lschuermann · 2018-06-27T22:44:46Z

Motivation for this change

With #26162 there already is an attempt to create a nix derivation for libvmi, which seems to have stagnated. This work is based off of this original pull request but resolves merge conflicts and updates the library to its current release, v0.12.

It also adds an option to disable Xen support entirely.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

I'm currently investigating whether it is also possible and makes sense to provide an option for disabling KVM support.
Additionally, for libvmi to work fast on KVM, they provide a patch for QEMU which integrates further debug interfaces. I'll test this patch and try to create another QEMU derivation with the libvmi integrations.

Fix incorrect license and change maintainer.

infinisil

@GrahamcOfBorg build libvmi

infinisil · 2018-07-01T16:14:01Z

pkgs/development/libraries/libvmi/default.nix

+  src = fetchFromGitHub {
+    owner = "libvmi";
+    repo = "libvmi";
+    rev = "6934e8a4758018983ec53ec791dd14a7d6ac31a9";


You can set version = "0.12.0", then use rev = "v${version}"

infinisil · 2018-07-01T16:18:31Z

pkgs/development/libraries/libvmi/default.nix

+    '';
+    license = with licenses; [ gpl3 lgpl3 ];
+    maintainers = with maintainers; [ lschuermann ];
+  };


Can you add the platforms attribute as well?

ryantm · 2018-07-03T02:22:40Z

@GrahamcOfBorg build libvmi

GrahamcOfBorg · 2018-07-03T02:23:05Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: libvmi

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-07-03T02:23:22Z

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: libvmi

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-07-03T02:23:56Z

Success on x86_64-linux (full log)

Attempted: libvmi

Partial log (click to expand)

shrinking /nix/store/78yg6ld6wny4ypp6kiqlx2jnhrllib3p-libvmi-0.12/lib/libvmi.so.0.0.12
shrinking /nix/store/78yg6ld6wny4ypp6kiqlx2jnhrllib3p-libvmi-0.12/bin/vmi-process-list
shrinking /nix/store/78yg6ld6wny4ypp6kiqlx2jnhrllib3p-libvmi-0.12/bin/vmi-module-list
shrinking /nix/store/78yg6ld6wny4ypp6kiqlx2jnhrllib3p-libvmi-0.12/bin/vmi-win-guid
shrinking /nix/store/78yg6ld6wny4ypp6kiqlx2jnhrllib3p-libvmi-0.12/bin/vmi-dump-memory
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/78yg6ld6wny4ypp6kiqlx2jnhrllib3p-libvmi-0.12/lib  /nix/store/78yg6ld6wny4ypp6kiqlx2jnhrllib3p-libvmi-0.12/bin
patching script interpreter paths in /nix/store/78yg6ld6wny4ypp6kiqlx2jnhrllib3p-libvmi-0.12
checking for references to /build in /nix/store/78yg6ld6wny4ypp6kiqlx2jnhrllib3p-libvmi-0.12...
/nix/store/78yg6ld6wny4ypp6kiqlx2jnhrllib3p-libvmi-0.12

infinisil · 2018-07-04T02:01:43Z

pkgs/development/libraries/libvmi/default.nix

+    sha256 = "0wbi2nasb1gbci6cq23g6kq7i10rwi1y7r44rl03icr5prqjpdyv";
+  };
+
+  buildInputs = [ glib which libvirt json_c ] ++ (optional xenSupport xen);


which is not needed.

I'll throw it out.

infinisil · 2018-07-04T02:02:32Z

pkgs/development/libraries/libvmi/default.nix

+  };
+
+  buildInputs = [ glib which libvirt json_c ] ++ (optional xenSupport xen);
+  nativeBuildInputs = [ autoreconfHook yacc bison flex libtool autoconf automake pkgconfig ];


yacc, autoconf and automake aren't needed.

Yes, you're right. I didn't question the inputs from @proteansec. Only one of either yacc or bison is required. I'll remove yacc.

I guess autoconf and automake are implicitly marked as nativeBuildInputs by autoreconfHook?
For me, it also builds successfully without libtool. I'll remove that too.

infinisil · 2018-07-04T02:03:26Z

pkgs/development/libraries/libvmi/default.nix

+      details of a running virtual machine by viewing its memory, trapping on hardware events,
+      and accessing the vCPU registers.
+    '';
+    license = with licenses; [ gpl3 lgpl3 ];


Why double licensed? I can only find LGPL3.0 in their repo

This also had me confused. Since this commit, they are dual licensed under the GPL3 and LGPL3. You'll find COPYING and COPYING.LESSER in the repo.

proteansec and others added 5 commits June 11, 2017 19:49

libvmi: init at 3e4114

b03bdc3

Merge remote-tracking branch 'proteansec/pkgs/libvmi' into libvmi

fc3073c

Fix incorrect license and change maintainer.

libvmi: -> 0.12

80a2a58

libvmi: Add option to disable xen support

f8086e3

libvmi: Add gpl3 license in addition to lgpl3

5505da9

GrahamcOfBorg added 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 labels Jun 27, 2018

infinisil requested changes Jul 1, 2018

View reviewed changes

Leon Schuermann added 2 commits July 3, 2018 18:17

libvmi: Use version tag as git revision

5d3d84b

libvmi: Add platforms metadata

c5dff34

lschuermann force-pushed the libvmi branch from c384f83 to c5dff34 Compare July 3, 2018 20:59

infinisil requested changes Jul 4, 2018

View reviewed changes

libvmi: Remove unnecessary dependencies

e6d5e95

infinisil approved these changes Jul 4, 2018

View reviewed changes

infinisil merged commit 6fd7f31 into NixOS:master Jul 4, 2018

infinisil mentioned this pull request Jul 4, 2018

libvmi: init at 3e4114 #26162

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

libvmi: init at 0.12 #42683

libvmi: init at 0.12 #42683

lschuermann commented Jun 27, 2018

infinisil left a comment

infinisil Jul 1, 2018

infinisil Jul 1, 2018

ryantm commented Jul 3, 2018

GrahamcOfBorg commented Jul 3, 2018

GrahamcOfBorg commented Jul 3, 2018

GrahamcOfBorg commented Jul 3, 2018

infinisil Jul 4, 2018

lschuermann Jul 4, 2018

infinisil Jul 4, 2018

lschuermann Jul 4, 2018

lschuermann Jul 4, 2018 •

edited

infinisil Jul 4, 2018

lschuermann Jul 4, 2018

libvmi: init at 0.12 #42683

libvmi: init at 0.12 #42683

Conversation

lschuermann commented Jun 27, 2018

Motivation for this change

Things done

infinisil left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ryantm commented Jul 3, 2018

GrahamcOfBorg commented Jul 3, 2018

GrahamcOfBorg commented Jul 3, 2018

GrahamcOfBorg commented Jul 3, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lschuermann Jul 4, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lschuermann Jul 4, 2018 •

edited