Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.flask-restful: disable broken test #42667

Merged
merged 1 commit into from Jun 27, 2018

Conversation

xvapx
Copy link
Contributor

@xvapx xvapx commented Jun 27, 2018

Motivation for this change

Fix #42641

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

nox-review fails due to #42640, already fixed in #42409

@@ -17,6 +17,9 @@ buildPythonPackage rec {
patchPhase = if isPy3k then ''
rm tests/test_crypto.py tests/test_paging.py
'' else null;
preCheck=''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do leave a comment here explaining what it is disabled for. Also, space at each side of =.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@xvapx
Copy link
Contributor Author

xvapx commented Jun 27, 2018

sorry, included wrong file squashing, fixing it now.
Ok, fixed.

@xvapx xvapx force-pushed the PR/fix-pythonPackages.flask-restful branch from a721ff5 to 3dd8b03 Compare June 27, 2018 19:39
@FRidh FRidh merged commit fd68302 into NixOS:master Jun 27, 2018
@xvapx xvapx deleted the PR/fix-pythonPackages.flask-restful branch June 27, 2018 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flask-restful tests fail broken with aniso8601 >3.0
3 participants