Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable parallel building for rtaudio and rtmidi #42678

Merged
merged 2 commits into from Jun 29, 2018
Merged

Enable parallel building for rtaudio and rtmidi #42678

merged 2 commits into from Jun 29, 2018

Conversation

Moredread
Copy link
Contributor

@Moredread Moredread commented Jun 27, 2018 •
edited

Motivation for this change

Enable parallel building for rtaudio and rtmidi.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@peterhoeg
Copy link
Member

Since these are libraries, please run nox-review.

@xeji
Copy link
Contributor

xeji commented Jun 29, 2018

@GrahamcOfBorg build rtaudio rtmidi i-score

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: rtaudio, rtmidi, i-score

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: rtaudio, rtmidi

The following builds were skipped because they don't evaluate on aarch64-linux: i-score

Partial log (click to expand)

make[1]: Leaving directory '/build/source/tests'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/w7ncf7b7rnhmnacd15m3i8j51n0vc5al-rtaudio-5.0.0
shrinking /nix/store/w7ncf7b7rnhmnacd15m3i8j51n0vc5al-rtaudio-5.0.0/lib/librtaudio.so.6.0.0
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/w7ncf7b7rnhmnacd15m3i8j51n0vc5al-rtaudio-5.0.0/lib
patching script interpreter paths in /nix/store/w7ncf7b7rnhmnacd15m3i8j51n0vc5al-rtaudio-5.0.0
checking for references to /build in /nix/store/w7ncf7b7rnhmnacd15m3i8j51n0vc5al-rtaudio-5.0.0...
/nix/store/w7ncf7b7rnhmnacd15m3i8j51n0vc5al-rtaudio-5.0.0
/nix/store/1xlqzfxnpmqnr9vz7l3kv74hyd9w07yw-rtmidi-2.1.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: rtaudio, rtmidi

The following builds were skipped because they don't evaluate on x86_64-linux: i-score

Partial log (click to expand)

make[1]: Leaving directory '/build/source/tests'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/643hqi2bfm5z3shrwsf49yl1d82p0s0q-rtaudio-5.0.0
shrinking /nix/store/643hqi2bfm5z3shrwsf49yl1d82p0s0q-rtaudio-5.0.0/lib/librtaudio.so.6.0.0
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/643hqi2bfm5z3shrwsf49yl1d82p0s0q-rtaudio-5.0.0/lib
patching script interpreter paths in /nix/store/643hqi2bfm5z3shrwsf49yl1d82p0s0q-rtaudio-5.0.0
checking for references to /build in /nix/store/643hqi2bfm5z3shrwsf49yl1d82p0s0q-rtaudio-5.0.0...
/nix/store/643hqi2bfm5z3shrwsf49yl1d82p0s0q-rtaudio-5.0.0
/nix/store/wrbh4jyam8vkzds7kzapv64ndj1indgb-rtmidi-2.1.1

@xeji xeji merged commit 9137f83 into NixOS:master Jun 29, 2018
@Moredread Moredread deleted the rtmidi/rtaudio/parallelBuild branch September 8, 2018 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Moredread @peterhoeg @xeji @GrahamcOfBorg