Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firebird-emu: init at 1.4 #42663

Merged
merged 2 commits into from Jun 28, 2018
Merged

firebird-emu: init at 1.4 #42663

merged 2 commits into from Jun 28, 2018

Conversation

kliu128
Copy link

@kliu128 kliu128 commented Jun 27, 2018

Motivation for this change

Firebird is an emulator for the TI-Nspire series calculators.

Things done

Successfully builds and runs on NixOS unstable. The executable is added to the path, and the desktop icon is installed correctly.

I haven't tested it on macOS, but Firebird does have macOS releases, so it should be possible to make it work.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Jun 27, 2018

@GrahamcOfBorg build firebird-emu

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: firebird-emu

Partial log (click to expand)

shrinking /nix/store/x94d9d3vyys12rsx232063j0x9pa4ifj-firebird-emu-1.4/bin/firebird-emu
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/x94d9d3vyys12rsx232063j0x9pa4ifj-firebird-emu-1.4/bin
patching script interpreter paths in /nix/store/x94d9d3vyys12rsx232063j0x9pa4ifj-firebird-emu-1.4
/nix/store/x94d9d3vyys12rsx232063j0x9pa4ifj-firebird-emu-1.4/bin/firebird-send: interpreter directive changed from "/bin/sh" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/x94d9d3vyys12rsx232063j0x9pa4ifj-firebird-emu-1.4...
postPatchMkspecs
postPatchMkspecs
postPatchMkspecs
/nix/store/x94d9d3vyys12rsx232063j0x9pa4ifj-firebird-emu-1.4

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: firebird-emu

Partial log (click to expand)

<artificial>:(.text+0x9fb4): relocation truncated to fit: R_AARCH64_LDST64_ABS_LO12_NC against symbol `translation_sp' defined in .data section in asmcode_aarch64.o
<artificial>:(.text+0x9fb4): warning: One possible cause of this error is that the symbol is being referenced in the indicated code as if it had a larger alignment than was declared where it was defined.
<artificial>:(.text+0xa000): relocation truncated to fit: R_AARCH64_LDST64_ABS_LO12_NC against symbol `translation_sp' defined in .data section in asmcode_aarch64.o
<artificial>:(.text+0xa000): warning: One possible cause of this error is that the symbol is being referenced in the indicated code as if it had a larger alignment than was declared where it was defined.
<artificial>:(.text+0xa078): relocation truncated to fit: R_AARCH64_LDST64_ABS_LO12_NC against symbol `translation_sp' defined in .data section in asmcode_aarch64.o
<artificial>:(.text+0xa078): warning: One possible cause of this error is that the symbol is being referenced in the indicated code as if it had a larger alignment than was declared where it was defined.
collect2: error: ld returned 1 exit status
make: *** [Makefile:338: firebird-emu] Error 1
builder for '/nix/store/iab872rn7kpapp6hk8i2kgvfmznl24rd-firebird-emu-1.4.drv' failed with exit code 2
error: build of '/nix/store/iab872rn7kpapp6hk8i2kgvfmznl24rd-firebird-emu-1.4.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: firebird-emu

Partial log (click to expand)

      wha_miss in asmcode_x86_64.o
     (maybe you meant: write_half_asm)
  "write_word", referenced from:
      wwa_miss in asmcode_x86_64.o
     (maybe you meant: write_word_asm)
ld: symbol(s) not found for architecture x86_64
clang-5.0: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [Makefile:345: firebird-emu.app/Contents/MacOS/firebird-emu] Error 1
builder for '/nix/store/aw598q4z52m0rr36h5q6hjlkrs9kmwbp-firebird-emu-1.4.drv' failed with exit code 2
�[31;1merror:�[0m build of '/nix/store/aw598q4z52m0rr36h5q6hjlkrs9kmwbp-firebird-emu-1.4.drv' failed

@xeji
Copy link
Contributor

xeji commented Jun 27, 2018

Looks like this will only work on the x86_64-linux platform.

@kliu128
Copy link
Author

kliu128 commented Jun 27, 2018 

ld: warning: ignoring file moc_emuthread.o, file was built for unsupported file format ( 0xDE 0xC0 0x17 0x0B 0x00 0x00 0x00 0x00 0x14 0x00 0x00 0x00 0xBC 0x95 0x06 0x00 ) which is not the architecture being linked (x86_64): moc_emuthread.o
...

Weird, is it not building for the correct architecture on Darwin? Anyway, not sure I can debug this without Mac hardware, so should I just set platforms to linux for the time being?

@xeji
Copy link
Contributor

xeji commented Jun 27, 2018

I guess that would be better for now.

firebird-emu: limit platform to linux
df0daf5 
Other platforms fail to compile currently.
@xeji xeji merged commit cb303b8 into NixOS:master Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kliu128 @xeji @GrahamcOfBorg