Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keybase-gui: 1.0.44 -> 2.3.0 #42733

Merged
merged 1 commit into from Jul 4, 2018
Merged

keybase-gui: 1.0.44 -> 2.3.0 #42733

merged 1 commit into from Jul 4, 2018

Conversation

jonafato
Copy link
Contributor

@jonafato jonafato commented Jun 28, 2018 •
edited

Motivation for this change

Upgrade keybase-gui to the latest release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@jonafato
keybase-gui: 1.0.44 -> 2.3.0
6c5bf24 
Upgrade keybase-gui to the latest release.
@peterhoeg
Copy link
Member

I assume that the 2 other keybase related PRs need to be merged together with this?

@jonafato
Copy link
Contributor Author

jonafato commented Jun 29, 2018 •
edited

@peterhoeg I tested all of the updates together but not individually. I can't guarantee that they don't work independently of each other, but there have been compatibility issues in the past, particularly with keybase-gui (e.g. #34395 (comment)).

@peterhoeg
Copy link
Member

That's why I asked ;-) Any chance you can build and test this (and the 2 others) with sandboxing enabled?

@xeji
Copy link
Contributor

xeji commented Jun 30, 2018

@GrahamcOfBorg build keybase-gui

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: keybase-gui

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/28c2ppi2m0rmkrbhgik3a8m0xhpsna7g-keybase-gui-2.3.0-20180627160031.8e0438e6fb
shrinking /nix/store/28c2ppi2m0rmkrbhgik3a8m0xhpsna7g-keybase-gui-2.3.0-20180627160031.8e0438e6fb/share/keybase/Keybase
shrinking /nix/store/28c2ppi2m0rmkrbhgik3a8m0xhpsna7g-keybase-gui-2.3.0-20180627160031.8e0438e6fb/share/keybase/libnode.so
shrinking /nix/store/28c2ppi2m0rmkrbhgik3a8m0xhpsna7g-keybase-gui-2.3.0-20180627160031.8e0438e6fb/share/keybase/libffmpeg.so
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/28c2ppi2m0rmkrbhgik3a8m0xhpsna7g-keybase-gui-2.3.0-20180627160031.8e0438e6fb/bin
patching script interpreter paths in /nix/store/28c2ppi2m0rmkrbhgik3a8m0xhpsna7g-keybase-gui-2.3.0-20180627160031.8e0438e6fb
/nix/store/28c2ppi2m0rmkrbhgik3a8m0xhpsna7g-keybase-gui-2.3.0-20180627160031.8e0438e6fb/share/keybase/post_install.sh: interpreter directive changed from " /usr/bin/env bash" to "/nix/store/p0vy17dp9jk2mvqsxsqnb14s3797lay7-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/28c2ppi2m0rmkrbhgik3a8m0xhpsna7g-keybase-gui-2.3.0-20180627160031.8e0438e6fb...
/nix/store/28c2ppi2m0rmkrbhgik3a8m0xhpsna7g-keybase-gui-2.3.0-20180627160031.8e0438e6fb

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: keybase-gui

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/4rj3l87lfbm0j8lri692qfmww0fna51r-keybase-gui-2.3.0-20180627160031.8e0438e6fb
shrinking /nix/store/4rj3l87lfbm0j8lri692qfmww0fna51r-keybase-gui-2.3.0-20180627160031.8e0438e6fb/share/keybase/Keybase
shrinking /nix/store/4rj3l87lfbm0j8lri692qfmww0fna51r-keybase-gui-2.3.0-20180627160031.8e0438e6fb/share/keybase/libffmpeg.so
shrinking /nix/store/4rj3l87lfbm0j8lri692qfmww0fna51r-keybase-gui-2.3.0-20180627160031.8e0438e6fb/share/keybase/libnode.so
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/4rj3l87lfbm0j8lri692qfmww0fna51r-keybase-gui-2.3.0-20180627160031.8e0438e6fb/bin
patching script interpreter paths in /nix/store/4rj3l87lfbm0j8lri692qfmww0fna51r-keybase-gui-2.3.0-20180627160031.8e0438e6fb
/nix/store/4rj3l87lfbm0j8lri692qfmww0fna51r-keybase-gui-2.3.0-20180627160031.8e0438e6fb/share/keybase/post_install.sh: interpreter directive changed from " /usr/bin/env bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/4rj3l87lfbm0j8lri692qfmww0fna51r-keybase-gui-2.3.0-20180627160031.8e0438e6fb...
/nix/store/4rj3l87lfbm0j8lri692qfmww0fna51r-keybase-gui-2.3.0-20180627160031.8e0438e6fb

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: keybase-gui

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@xeji
Copy link
Contributor

xeji commented Jun 30, 2018

Should be merged after #42731.

@jonafato
Copy link
Contributor Author

jonafato commented Jul 3, 2018

@peterhoeg Tested all three packages together using sandboxing, everything seems good.

@peterhoeg peterhoeg merged commit 3c8457e into NixOS:master Jul 4, 2018
@jonafato jonafato deleted the keybase-gui-2.3.0 branch July 4, 2018 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jonafato @peterhoeg @xeji @GrahamcOfBorg