Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keybase: 2.0.0 -> 2.1.0 #42731

Merged
merged 1 commit into from Jul 4, 2018
Merged

keybase: 2.0.0 -> 2.1.0 #42731

merged 1 commit into from Jul 4, 2018

Conversation

jonafato
Copy link
Contributor

@jonafato jonafato commented Jun 28, 2018 •
edited

Motivation for this change

Keybase has a new minor release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Jun 30, 2018

@GrahamcOfBorg build keybase

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: keybase

Partial log (click to expand)


trying https://github.com/keybase/client/archive/v2.1.0.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   122    0   122    0     0    311      0 --:--:-- --:--:-- --:--:--   311
100 32.8M  100 32.8M    0     0  15.3M      0  0:00:02  0:00:02 --:--:-- 20.6M
unpacking source archive /build/v2.1.0.tar.gz
fixed-output derivation produced path '/nix/store/djapnv3msibybqamnjf87ygbqlnp6q8q-source' with sha256 hash '16izsx5944byc930i6pqsbyrp316yyy8z5xvmzj0g8rgawajdx5h' instead of the expected hash '09z4vbni2d2vz8hzgw9r8ywcl2lbzzspjzs8k9qk6j4iki865vq8'
cannot build derivation '/nix/store/9vf6a6ymsj84vk2y7bhn5vznz5xrk3k2-keybase-2.1.0.drv': 1 dependencies couldn't be built
error: build of '/nix/store/9vf6a6ymsj84vk2y7bhn5vznz5xrk3k2-keybase-2.1.0.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: keybase

Partial log (click to expand)


trying https://github.com/keybase/client/archive/v2.1.0.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   122    0   122    0     0   1207      0 --:--:-- --:--:-- --:--:--  1207
100 32.8M  100 32.8M    0     0  39.4M      0 --:--:-- --:--:-- --:--:-- 39.4M
unpacking source archive /build/v2.1.0.tar.gz
fixed-output derivation produced path '/nix/store/djapnv3msibybqamnjf87ygbqlnp6q8q-source' with sha256 hash '16izsx5944byc930i6pqsbyrp316yyy8z5xvmzj0g8rgawajdx5h' instead of the expected hash '09z4vbni2d2vz8hzgw9r8ywcl2lbzzspjzs8k9qk6j4iki865vq8'
cannot build derivation '/nix/store/yrj6vpa7n54qpyb55g2f6whzdl4yhxnl-keybase-2.1.0.drv': 1 dependencies couldn't be built
error: build of '/nix/store/yrj6vpa7n54qpyb55g2f6whzdl4yhxnl-keybase-2.1.0.drv' failed

xeji
xeji reviewed Jun 30, 2018
View reviewed changes
Copy link
Contributor

@xeji xeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hash mismatch. If the hash changed for the same version it might be better to pin fetchFromGitHub to a git commit.

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: keybase

Partial log (click to expand)


trying https://github.com/keybase/client/archive/v2.1.0.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   122    0   122    0     0    234      0 --:--:-- --:--:-- --:--:--   234
100 32.8M  100 32.8M    0     0  7831k      0  0:00:04  0:00:04 --:--:-- 9504k
unpacking source archive /private/tmp/nix-build-source.drv-0/v2.1.0.tar.gz
fixed-output derivation produced path '/nix/store/djapnv3msibybqamnjf87ygbqlnp6q8q-source' with sha256 hash '16izsx5944byc930i6pqsbyrp316yyy8z5xvmzj0g8rgawajdx5h' instead of the expected hash '09z4vbni2d2vz8hzgw9r8ywcl2lbzzspjzs8k9qk6j4iki865vq8'
cannot build derivation '/nix/store/ga0drxcky4h6d1y9lk27isc0cdzs7si3-keybase-2.1.0.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/ga0drxcky4h6d1y9lk27isc0cdzs7si3-keybase-2.1.0.drv' failed

This was referenced Jun 30, 2018
Merged
Merged
@jonafato
keybase: 2.0.0 -> 2.1.0
7b47a07 
Keybase has a new minor release.
@jonafato
Copy link
Contributor Author

jonafato commented Jul 3, 2018

@xeji Hash fixed. Nothing changed, it was my mistake (I updated the version but not the hash after changing it twice).

@peterhoeg
Copy link
Member

@GrahamcOfBorg build keybase

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: keybase

Partial log (click to expand)

/nix/store/pm4gwd1vm86n5pr2kzrgmp11jna8bd1k-keybase-2.1.0/share/go/src/github.com/keybase/client/go/test/run_tests.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
/nix/store/pm4gwd1vm86n5pr2kzrgmp11jna8bd1k-keybase-2.1.0/share/go/src/github.com/keybase/client/go/test/nuke_kbweb.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
/nix/store/pm4gwd1vm86n5pr2kzrgmp11jna8bd1k-keybase-2.1.0/share/go/src/github.com/keybase/client/go/test/check_or_start_kbweb.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
/nix/store/pm4gwd1vm86n5pr2kzrgmp11jna8bd1k-keybase-2.1.0/share/go/src/github.com/keybase/client/go/vendor/golang.org/x/sys/unix/mkerrors.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
/nix/store/pm4gwd1vm86n5pr2kzrgmp11jna8bd1k-keybase-2.1.0/share/go/src/github.com/keybase/client/go/vendor/golang.org/x/sys/unix/mkall.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
/nix/store/pm4gwd1vm86n5pr2kzrgmp11jna8bd1k-keybase-2.1.0/share/go/src/github.com/keybase/client/go/vendor/github.com/keybase/keybase-test-vectors/teamchains/compile.sh: interpreter directive changed from "/bin/sh" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/sh"
/nix/store/pm4gwd1vm86n5pr2kzrgmp11jna8bd1k-keybase-2.1.0/share/go/src/github.com/keybase/client/go/vendor/github.com/keybase/go-codec/codec/tests.sh: interpreter directive changed from "/bin/bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
/nix/store/pm4gwd1vm86n5pr2kzrgmp11jna8bd1k-keybase-2.1.0/share/go/src/github.com/keybase/client/go/vendor/github.com/keybase/go-codec/codec/prebuild.sh: interpreter directive changed from "/bin/bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/pm4gwd1vm86n5pr2kzrgmp11jna8bd1k-keybase-2.1.0...
/nix/store/abzc7vii4b8plzr9k5hp5yl082a9br2n-keybase-2.1.0-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: keybase

Partial log (click to expand)

/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
checking for references to /build in /nix/store/5s9msigp71wm51adcpr2mn56zwgypf15-keybase-2.1.0...
/nix/store/z6hy8jliwnpkyasjbsrdsbbbs4r5343m-keybase-2.1.0-bin

@peterhoeg peterhoeg merged commit a12ddd3 into NixOS:master Jul 4, 2018
@jonafato jonafato deleted the keybase-2.1.0 branch July 4, 2018 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jonafato @xeji @GrahamcOfBorg @peterhoeg