Fix libyaml 0.2.1 incompatibility #6287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libyaml 0.2.1 removed the errorneously written document end marker (`...`) after some scalars in root context (see yaml/libyaml#18). Earlier libyaml releases still write the document end marker and this is hard to fix on Crystal's side. So we just ignore it and adopt the specs accordingly to coincide with the used libyaml version.
|
It’s a pitty that then a guard would be needed on a new libyaml release to turn on the end of document again... Or maybe as times goes we can think that 0.2.1 is yanked. |
bcardiff
approved these changes
Jun 29, 2018
|
One more reason to have our pure Crystal version of |
sdogruyol
approved these changes
Jun 29, 2018
|
@bcardiff Why would we need to change on a new libyaml release? I don't expect it to switch back the previous, incorrect behaviour. It was a bug fix. Our specs now take the bug into account if libyaml < 0.2.1 |
|
Oh, i read it wrong. I thought it was a regression introduced in 0.2.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6283
libyaml 0.2.1 removed the errorneously written document end marker (
...) after some scalars in root context (see yaml/libyaml#18).Earlier libyaml releases still write the document end marker and both older and newer releases need to be supported.
This implements modifying the expected value depending on the version of libyaml as suggested in #6285 (comment).
I don't think it is feasible to implement the fix for libyaml < 0.2.1 in Crystal as suggested in #6285 (comment). This would make
YAMLalways behave the same, whatever version of libyaml it is used with. But it would require rewriting the output written to the builderIOby libyaml. Since the impact is pretty small - YAML documents consisting of only a scalar are pretty rare outside of test suites.