rainloop: Init at 1.12.1 #42740
Merged
rainloop: Init at 1.12.1 #42740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Jun 28, 2018
pkgs/servers/rainloop/default.nix
Outdated
| @@ -0,0 +1,33 @@ | |||
| { stdenv, fetchurl, unzip, dataPath ? "/etc/rainloop", | |||
| edition ? "", hash ? "bf558752ce5035dc036702878f453fa4ba3da68c25e77271a079ac285d8acf76" }: stdenv.mkDerivation rec { | |||
There was a problem hiding this comment.
I don't think we need to expose edition or hash.
It is easy to enough to override them with:
rainloop.overrideAttrs (old: {
src = fetchurl {
url = "https://github.com/RainLoop/rainloop-webmail/releases/download/v${version}/rainloop-professional${version}.zip";
sha256 = "<new-hash>";
};
})
Mic92
requested changes
Jun 28, 2018
pkgs/servers/rainloop/default.nix
Outdated
| license = licenses.agpl3; | ||
| platforms = platforms.all; | ||
| maintainers = with maintainers; [ das_j ]; | ||
| }; |
There was a problem hiding this comment.
Can you add a common function like here? https://github.com/NixOS/nixpkgs/blob/master/pkgs/servers/sql/postgresql/default.nix
pkgs/top-level/all-packages.nix
Outdated
| hash = "0hz9pqz398hnflx26nngdfijzmdqmxh4vi568w2974l55hzml1v8"; | ||
| }; | ||
|
|
||
| rainloop-standard = callPackage ../servers/rainloop { }; |
There was a problem hiding this comment.
Then this would be become:
inherit (callPackages ../servers/rainloop { }) rainloop-community rainloop-standard;
|
@Mic92 Thank you for that great suggestion! I rewrote and rebased it according to your proposal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I'm using rainloop webmail on my legacy (non-NixOS) servers.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)