Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nix-review: 0.2.0 -> 0.3.0 #42744

Merged
merged 1 commit into from Jun 29, 2018
Merged

nix-review: 0.2.0 -> 0.3.0 #42744

merged 1 commit into from Jun 29, 2018

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jun 28, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip" nix-review pr 42744
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member Author

Mic92 commented Jun 28, 2018

mass reviews work now:

$ nix-review pr 42711-42713 # or separated by spaces

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: nix-review

Partial log (click to expand)

$ git worktree prune
$ git fetch --force https://github.com/NixOS/nixpkgs master:refs/nix-review/0 pull/1/head:refs/nix-review/1
$ git worktree add ./.review/pr-1 hash1
$ git merge --no-commit hash2
Building in /build/nox-review-opnywble: pong3d
$ nix-shell --no-out-link --keep-going --max-jobs 8 --option build-use-sandbox true --run true --builders ssh://joerg@10.243.29.170 aarch64-linux -p pong3d
https://github.com/NixOS/nixpkgs/pull/1
$ nix-shell -p pong3d
$ git worktree prune
/nix/store/inz08m7s1iv39vqfwgc4iamhhmzi151n-nix-review-0.3.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: nix-review

Partial log (click to expand)

$ git worktree prune
$ git fetch --force https://github.com/NixOS/nixpkgs master:refs/nix-review/0 pull/1/head:refs/nix-review/1
$ git worktree add ./.review/pr-1 hash1
$ git merge --no-commit hash2
Building in /build/nox-review-op5r62d7: pong3d
$ nix-shell --no-out-link --keep-going --max-jobs 96 --option build-use-sandbox true --run true --builders ssh://joerg@10.243.29.170 aarch64-linux -p pong3d
https://github.com/NixOS/nixpkgs/pull/1
$ nix-shell -p pong3d
$ git worktree prune
/nix/store/kcbw11vcv8blwwamc8radxgx07n4c71c-nix-review-0.3.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: nix-review

Partial log (click to expand)

$ git worktree prune
$ git fetch --force https://github.com/NixOS/nixpkgs master:refs/nix-review/0 pull/1/head:refs/nix-review/1
$ git worktree add ./.review/pr-1 hash1
$ git merge --no-commit hash2
Building in /private/tmp/nix-build-nix-review-0.3.0.drv-0/nox-review-_cqbgv60: pong3d
$ nix-shell --no-out-link --keep-going --max-jobs 2 --option build-use-sandbox true --run true --builders ssh://joerg@10.243.29.170 aarch64-linux -p pong3d
https://github.com/NixOS/nixpkgs/pull/1
$ nix-shell -p pong3d
$ git worktree prune
/nix/store/hpscgbcnll1k1lm9449012g3j0cs6lbn-nix-review-0.3.0

@FRidh FRidh merged commit f67573e into NixOS:master Jun 29, 2018
@Mic92 Mic92 deleted the nix-review branch June 29, 2018 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @GrahamcOfBorg @FRidh