Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firefox, firefox-bin: 60.0.2 -> 61.0, firefox-esr: 52.8.1esr -> 52.9.0esr, 60.0.2esr -> 60.1.0esr, nss: 3.36.4 -> 3.38 [Critical security fixes] #42729

Merged
merged 4 commits into from Jun 29, 2018
Merged

firefox, firefox-bin: 60.0.2 -> 61.0, firefox-esr: 52.8.1esr -> 52.9.0esr, 60.0.2esr -> 60.1.0esr, nss: 3.36.4 -> 3.38 [Critical security fixes] #42729

merged 4 commits into from Jun 29, 2018

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Jun 28, 2018 •
edited

Motivation for this change
  • Critical security fixes
  • Other improvements and fixes

https://www.mozilla.org/en-US/firefox/61.0/releasenotes/
https://www.mozilla.org/en-US/firefox/60.1.0/releasenotes/
https://www.mozilla.org/en-US/firefox/52.9.0/releasenotes/
https://www.mozilla.org/en-US/security/advisories/mfsa2018-15/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@oxij oxij mentioned this pull request Jun 28, 2018
Closed
9 tasks
@andir
Copy link
Member

andir commented Jun 28, 2018 •
edited

The changes look good so far. For version >=61 you might want to remove system hunspell support (https://bugzilla.mozilla.org/show_bug.cgi?id=1460600).

@taku0
Copy link
Contributor Author

taku0 commented Jun 29, 2018

Sorry, I didn't notice the existing PR. Incorporated changes from #42631.

vcunat added a commit that referenced this pull request Jun 29, 2018
@vcunat
Merge #42729: firefox updates (critical security)
4af706b 
The commits are really cherry-picked from the PR.
@vcunat
Copy link
Member

vcunat commented Jun 29, 2018

I briefly tested these on x86_64-linux, and all 18.03* channels now contain this. The rebuild isn't really that big (a couple thousand).

@vcunat vcunat merged commit 9662c68 into NixOS:staging Jun 29, 2018
vcunat added a commit that referenced this pull request Jun 29, 2018
@vcunat
Merge #42729: firefox-61 and related updates (security)
8ad921d
vcunat added a commit that referenced this pull request Jun 29, 2018
@vcunat
Merge #42729: firefox-61 and related updates (security)
2f4001f 
(cherry picked from commit 8ad921d)
Fast-forwarded to get to master sooner.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@taku0 @andir @vcunat @GrahamcOfBorg