Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spec: silence errors from system_spec on BSD platforms #6289

Merged
merged 1 commit into from Jun 29, 2018
Merged

Spec: silence errors from system_spec on BSD platforms #6289

merged 1 commit into from Jun 29, 2018

Conversation

jcs
Copy link
Contributor

@jcs jcs commented Jun 28, 2018

On platforms where getconf _NPROCESSORS_ONLN doesn't work, like OpenBSD, each command emits an error:

Before:

$ crystal spec spec/std/system_spec.cr 
/usr/local/lib/libevent_core.so.1.1: warning: random() may return deterministic values, is that what you want?
.getconf: _NPROCESSORS_ONLN: unknown variable
-: nproc: not found
grep: /proc/cpuinfo: No such file or directory
.

Finished in 16.14 milliseconds
2 examples, 0 failures, 0 errors, 0 pending

After:

$ crystal spec spec/std/system_spec.cr
/usr/local/lib/libevent_core.so.1.1: warning: random() may return deterministic values, is that what you want?
..

Finished in 16.03 milliseconds
2 examples, 0 failures, 0 errors, 0 pending

@RX14 RX14 merged commit bfd9e6d into crystal-lang:master Jun 29, 2018
@RX14 RX14 added this to the Next milestone Jun 29, 2018
@RX14 RX14 modified the milestones: Next, 0.26.0 Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhass jhass jhass approved these changes

@bcardiff bcardiff bcardiff approved these changes

@RX14 RX14 RX14 approved these changes

Assignees
No one assigned
Labels
kind:bug topic:stdlib:specs topic:stdlib
Projects
None yet
Milestone
0.26.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jcs @jhass @bcardiff @RX14