Fix: generic Socket#accept? is broken (#6277)

crystal-lang · Jun 28, 2018 · bf85d7a · bf85d7a
1 parent b0d67e1
commit bf85d7a
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/spec/std/socket_spec.cr b/spec/std/socket_spec.cr
@@ -74,6 +74,19 @@ describe Socket do
       sock.type.should eq(Socket::Type::DGRAM)
     end
   end
+
+  it ".accept" do
+    server = Socket.new(Socket::Family::INET, Socket::Type::STREAM, Socket::Protocol::TCP)
+    server.bind("0.0.0.0", 11234)
+    server.listen
+
+    spawn { TCPSocket.new("127.0.0.1", 11234).close }
+
+    client = server.accept
+    client.family.should eq(Socket::Family::INET)
+    client.type.should eq(Socket::Type::STREAM)
+    client.protocol.should eq(Socket::Protocol::TCP)
+  end
 end
 
 describe Socket::Addrinfo do

diff --git a/src/socket.cr b/src/socket.cr
@@ -228,7 +228,7 @@ class Socket < IO
   # ```
   def accept?
     if client_fd = accept_impl
-      sock = Socket.new(client_fd)
+      sock = Socket.new(client_fd, family, type, protocol, blocking)
       sock.sync = sync?
       sock
     end