Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos: add system.nixos.stateVersion alias (18.03) #42749

Closed
wants to merge 1 commit into from
Closed

nixos: add system.nixos.stateVersion alias (18.03) #42749

wants to merge 1 commit into from

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Jun 28, 2018

Motivation for this change

The stateVersion option has been renamed in 18.09pre, so this adds forwards
compatibility for configurations that use the new option.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@LnL7
nixos: add system.nixos.stateVersion alias
9119c4f 
The stateVersion option has been renamed in 18.09pre, so this adds forwards
compatibility for configurations that use the new option.
@LnL7 LnL7 force-pushed the stateversion-forwards-compatible branch from d7d7e23 to 9119c4f Compare June 28, 2018 23:55
@LnL7 LnL7 changed the title nixos: add system.nixos.stateVersion alias nixos: add system.nixos.stateVersion alias (18.03) Jun 29, 2018
@dezgeg
Copy link
Contributor

dezgeg commented Jun 29, 2018

I vote we revert the rename of the option, and document that randomly renaming options is bad exactly for these reasons so that this won't keep happening again.

@LnL7
Copy link
Member Author

LnL7 commented Jun 29, 2018

That's also an option, but there are probably a bunch of nixos-unstable uses that switched now because of the deprecation warning.

@dezgeg
Copy link
Contributor

dezgeg commented Jul 25, 2018

I guess we can let @edolstra decide.

@edolstra
Copy link
Member

Unless there was a very compelling reason for renaming system.stateVersion, I'd say revert it.

@LnL7 Regarding users who may have already switched, well that's the risk of living on the unstable branch ;-)

@LnL7
Copy link
Member Author

LnL7 commented Jul 25, 2018

That's fair, just wanted to mention it since it's been part of unstable for some time now. I didn't look into why this was renamed but I agree that it's probably not a good idea.

@dezgeg
Copy link
Contributor

dezgeg commented Jul 25, 2018

Revert in #44107

@LnL7
Copy link
Member Author

LnL7 commented Jul 27, 2018

Closing since #44107 was merged.

@LnL7 LnL7 closed this Jul 27, 2018
@LnL7 LnL7 deleted the stateversion-forwards-compatible branch July 27, 2018 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer approved these changes

Assignees

@edolstra edolstra

Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@LnL7 @dezgeg @edolstra @matthewbauer @GrahamcOfBorg