Update parseResponseHeaders to work in fastboot. #5502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanto
changed the title
|
hmm. not sure what to do about this failure: https://travis-ci.org/emberjs/data/jobs/396162028 |
|
@ryanto if you rebase I pinned the offending package and your test run will continue :) |
On nix systems the headers will be delimited with only a newline (\n) character. This PR changes the split to \r?\n, which will work for all fastboot environments as well as browsers.
ryanto
force-pushed
the
fastboot-handleresponse-headers
branch
from
73240ca
to
6acdbee
Compare
rwjblue
pushed a commit
that referenced
this pull request
Jun 29, 2018
* Update parseResponseHeaders so it works in fastboot. On nix systems the headers will be delimited with only a newline (\n) character. This PR changes the split to \r?\n, which will work for all fastboot environments as well as browsers. * Fix eslint errors (cherry picked from commit d584076)
NullVoxPopuli
pushed a commit
to NullVoxPopuli/data
that referenced
this pull request
Sep 8, 2018
* Update parseResponseHeaders so it works in fastboot. On nix systems the headers will be delimited with only a newline (\n) character. This PR changes the split to \r?\n, which will work for all fastboot environments as well as browsers. * Fix eslint errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On nix systems the headers will be delimited with only a newline (
\n) character.This PR changes the split to
\r?\n, which will work for all fastboot environments as well as browsers.