Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick pgmanage-10.3.0 on release-18.03 #42427

Merged
merged 4 commits into from Jun 24, 2018
Merged

Cherry-pick pgmanage-10.3.0 on release-18.03 #42427

merged 4 commits into from Jun 24, 2018

Conversation

basvandijk
Copy link
Member

Motivation for this change

release-18.03 contains pgmanage-10.1.0. Since then there have been two releases containing useful bugfixes:

This just cherry-picks the relevant commits on release-18.03.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

lsix and others added 4 commits June 23, 2018 13:43
@lsix @basvandijk
pgmanage: fix build
58845d3 
The configure script uses the `command` builtin command which is bash
specific while having a "#!/bin/sh" head.

This forces the use nix default shell (bash)

(cherry picked from commit 159a021)
(cherry picked from commit 2653355)
@basvandijk
pgmanage: 10.1.0 -> 10.1.1
b3beddd 
(cherry picked from commit 65b1c73)
@ariutta @basvandijk
pgmanage: update to current name (minor).
e3f190c 
(cherry picked from commit c218cd3)
@basvandijk
pgmanage: 10.1.1 -> 10.3.0
289f811 
Release notes: https://github.com/pgManage/pgManage/releases/tag/v10.3.0

Also fixes NixOS#40247

(cherry picked from commit e385630)
@basvandijk basvandijk mentioned this pull request Jun 24, 2018
Merged
9 tasks
@xeji
Copy link
Contributor

xeji commented Jun 24, 2018

@GrahamcOfBorg build pgmanage

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pgmanage

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/n3my4mxyr8g6h2jyrxp1v84lg25mzykw-pgmanage-10.3.0
shrinking /nix/store/n3my4mxyr8g6h2jyrxp1v84lg25mzykw-pgmanage-10.3.0/sbin/pgmanage
gzipping man pages under /nix/store/n3my4mxyr8g6h2jyrxp1v84lg25mzykw-pgmanage-10.3.0/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/n3my4mxyr8g6h2jyrxp1v84lg25mzykw-pgmanage-10.3.0/sbin
patching script interpreter paths in /nix/store/n3my4mxyr8g6h2jyrxp1v84lg25mzykw-pgmanage-10.3.0
checking for references to /build in /nix/store/n3my4mxyr8g6h2jyrxp1v84lg25mzykw-pgmanage-10.3.0...
moving /nix/store/n3my4mxyr8g6h2jyrxp1v84lg25mzykw-pgmanage-10.3.0/sbin/* to /nix/store/n3my4mxyr8g6h2jyrxp1v84lg25mzykw-pgmanage-10.3.0/bin
/nix/store/n3my4mxyr8g6h2jyrxp1v84lg25mzykw-pgmanage-10.3.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pgmanage

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/97wx28czq03flvbh2949nkg2hhvmz0qx-pgmanage-10.3.0
shrinking /nix/store/97wx28czq03flvbh2949nkg2hhvmz0qx-pgmanage-10.3.0/sbin/pgmanage
gzipping man pages under /nix/store/97wx28czq03flvbh2949nkg2hhvmz0qx-pgmanage-10.3.0/share/man/
strip is /nix/store/ppn001bfygzlqx4h50n9zgxc3kqv2d6k-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/97wx28czq03flvbh2949nkg2hhvmz0qx-pgmanage-10.3.0/sbin
patching script interpreter paths in /nix/store/97wx28czq03flvbh2949nkg2hhvmz0qx-pgmanage-10.3.0
checking for references to /build in /nix/store/97wx28czq03flvbh2949nkg2hhvmz0qx-pgmanage-10.3.0...
moving /nix/store/97wx28czq03flvbh2949nkg2hhvmz0qx-pgmanage-10.3.0/sbin/* to /nix/store/97wx28czq03flvbh2949nkg2hhvmz0qx-pgmanage-10.3.0/bin
/nix/store/97wx28czq03flvbh2949nkg2hhvmz0qx-pgmanage-10.3.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: pgmanage

Partial log (click to expand)

install man/man1/pgmanage.1 //nix/store/b3z2m997i326v8471ibfp865wpmjnspw-pgmanage-10.3.0/share/man/man1/pgmanage.1

Installation Successful
post-installation fixup
gzipping man pages under /nix/store/b3z2m997i326v8471ibfp865wpmjnspw-pgmanage-10.3.0/share/man/
strip is /nix/store/bvxfljaqw2qnkd7n1ab88bd67x4giwld-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/b3z2m997i326v8471ibfp865wpmjnspw-pgmanage-10.3.0/sbin
patching script interpreter paths in /nix/store/b3z2m997i326v8471ibfp865wpmjnspw-pgmanage-10.3.0
moving /nix/store/b3z2m997i326v8471ibfp865wpmjnspw-pgmanage-10.3.0/sbin/* to /nix/store/b3z2m997i326v8471ibfp865wpmjnspw-pgmanage-10.3.0/bin
/nix/store/b3z2m997i326v8471ibfp865wpmjnspw-pgmanage-10.3.0

@xeji xeji merged commit 9353294 into NixOS:release-18.03 Jun 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@basvandijk @xeji @GrahamcOfBorg @lsix @ariutta