Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nvidia-x11: pass kernel.modDirVersion #42516

Merged
merged 1 commit into from Jun 26, 2018
Merged

nvidia-x11: pass kernel.modDirVersion #42516

merged 1 commit into from Jun 26, 2018

Conversation

dukzcry
Copy link

@dukzcry dukzcry commented Jun 24, 2018

Motivation for this change

Don't figure modules directory in builder, pass it as variable from nix expression instead.

We need this for nvidia optimus script to work on non-NixOS:
https://nixos.wiki/wiki/nvidia#Nvidia_PRIME
dukzcry/crap#3 (comment)

We override nix packages in script so modules could be built against kernel on non-NixOS:
https://github.com/dukzcry/crap/blob/master/primerun/primerun.sh#L187

cast @crzyBrown (script user), @vcunat (nvidia package maintainer)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@dukzcry
Copy link
Author

dukzcry commented Jun 26, 2018

@fpletz Cool, thank you much :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants