Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "python: jupyterlab_launcher: 0.10.5 -> 0.11.0" #42442

Merged
merged 1 commit into from Jun 23, 2018
Merged

Revert "python: jupyterlab_launcher: 0.10.5 -> 0.11.0" #42442

merged 1 commit into from Jun 23, 2018

Conversation

averelld
Copy link
Contributor

This reverts commit a4404ad.

Motivation for this change

Upgrade was part of the mass-upgrade in #41894 but this launcher version is not compatible with the latest released jupyterlab.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@averelld averelld requested a review from FRidh as a code owner June 23, 2018 15:55
@FRidh FRidh merged commit 509eb61 into NixOS:master Jun 23, 2018
@averelld averelld deleted the fix-jupyterlab-build branch June 23, 2018 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@averelld @FRidh