krop: init -> 0.5.0 #42535
Merged
krop: init -> 0.5.0 #42535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pSub
reviewed
Jun 25, 2018
| ghostscript | ||
| ]; | ||
|
|
||
| doCheck = false; |
| homepage = http://arminstraub.com/software/krop; | ||
| description = "Graphical tool to crop the pages of PDF files"; | ||
| longDescription = '' | ||
|
|
There was a problem hiding this comment.
Nitpick: Maybe remove that empty line?
|
Empty line removed as suggested. The reason to disable tests is that there is an interference with different versions of Qt installed in the build profile. This leads to an error: qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in "" Once installed, the application works exactly like it should. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
A useful graphical and command line tool that solves a real need: cropping PDF's. Useful to clean up scans etc.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)