Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strongswan-swanctl: adapt options to strongswan-5.6.3 #42518

Merged
merged 1 commit into from Jun 25, 2018
Merged

strongswan-swanctl: adapt options to strongswan-5.6.3 #42518

merged 1 commit into from Jun 25, 2018

Conversation

basvandijk
Copy link
Member

Motivation for this change

strongswan-5.6.3 is now in nixpkgs. This updates the strongswan-swanctl module to the changes in options for that release. This time there was only one change between 5.6.2..5.6.3.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@basvandijk
strongswan-swanctl: adapt options to strongswan-5.6.3
4013702 
This time there was only one change between 5.6.2..5.6.3:

strongswan/strongswan@2c7a4b0
@xeji
Copy link
Contributor

xeji commented Jun 25, 2018

@GrahamcOfBorg test strongswan-swanctl

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.strongswan-swanctl

Partial log (click to expand)

test script finished in 32.77s
cleaning up
killing alice (pid 628)
killing carol (pid 641)
killing moon (pid 654)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: vde_switch: Could not remove ctl dir '/build/vde0.ctl': Directory not emptyCould not remove ctl dir '/build/vde1.ctl': Directory not empty

/nix/store/gmxgjxnh0m95r9igprwwhj5j84ldpcjp-vm-test-run-strongswan-swanctl

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.strongswan-swanctl

Partial log (click to expand)

test script finished in 29.71s
cleaning up
killing alice (pid 594)
killing carol (pid 606)
killing moon (pid 618)
vde_switch: EOF on stdin, cleaning up and exitingvde_switch:
EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
vde_switch: Could not remove ctl dir '/build/vde0.ctl': Directory not empty
/nix/store/fabqa1152k6xmaj3cg3bjic6m1fw8fqm-vm-test-run-strongswan-swanctl

@xeji xeji merged commit 7e77094 into NixOS:master Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@basvandijk @xeji @GrahamcOfBorg