Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JSON::Any#dup and YAML::Any#dup #6251

Closed
wants to merge 1 commit into from
Closed

Add JSON::Any#dup and YAML::Any#dup #6251

wants to merge 1 commit into from

Conversation

asterite
Copy link
Member

Fixes #6220

@Sija
Copy link
Contributor

Sija commented Jun 23, 2018

Let's add #clone too perhaps?

@asterite
Copy link
Member Author

Oh, I thought that was defined on struct. I'll do it in a few days

@asterite
Copy link
Member Author

Discussion right now on gitter, people wondering why there's [] but not each... I think it's time to remove all methods from json any, and just let it be a thin wrapper. Want to work with it? Fetch the raw value and cast it. No more confusion.

@asterite asterite closed this Jun 24, 2018
@bcardiff bcardiff mentioned this pull request Jun 25, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asterite @Sija