Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add installCheckTarget and installCheckFlags to manual #42464

Merged
merged 1 commit into from Aug 31, 2018
Merged

doc: add installCheckTarget and installCheckFlags to manual #42464

merged 1 commit into from Aug 31, 2018

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Jun 23, 2018 •
edited

Fixes #42393

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@LnL7
Copy link
Member Author

LnL7 commented Aug 30, 2018

@GrahamcOfBorg eval

@LnL7 LnL7 merged commit 477efb9 into NixOS:master Aug 31, 2018
@LnL7 LnL7 deleted the manual-installcheck branch August 31, 2018 18:08
@xeji
Copy link
Contributor

xeji commented Aug 31, 2018 •
edited

This breaks eval of the nixos tests:

$ git rev-parse HEAD
477efb9d8752799c4de7b93289f3be35c3d7ea86

$ nix-instantiate nixos/release.nix -A tests.atd
error: stack overflow (possible infinite recursion)

... (one commit before)

HEAD is now at c49baf9da44 shotcut: 18.08 -> 18.08.14 (#45862)

$ nix-instantiate nixos/release.nix -A tests.atd
warning: you did not specify '--add-root'; the result might be removed by the garbage collector
/nix/store/5fw3r38z147h0iglyqcj0p9mm6j4lrcw-vm-test-run-atd.drv
/nix/store/5x87l52fr7049311w07agimiv2mvm428-vm-test-run-atd.drv

Edit: happens for all tests, not just this one.

@LnL7
Copy link
Member Author

LnL7 commented Aug 31, 2018

Huh!

@LnL7
Copy link
Member Author

LnL7 commented Aug 31, 2018

@xeji Are you sure?

$ git rev-parse HEAD
477efb9d8752799c4de7b93289f3be35c3d7ea86

$ nix-instantiate nixos/release.nix -A tests.atd
warning: you did not specify '--add-root'; the result might be removed by the garbage collector
/nix/store/kfllh170qnn5y2mzjqlqgz8xkxfiivr4-vm-test-run-atd.drv
/nix/store/w4k94m7cl2g8sn8yvy7vlnc4923dc1gb-vm-test-run-atd.drv

@xeji
Copy link
Contributor

xeji commented Aug 31, 2018

Yes, tried again, same result, only on this commit. Maybe my repo clone is corrupt, let me check it.

@xeji
Copy link
Contributor

xeji commented Aug 31, 2018

It's fine on a fresh clone of nixpkgs.

What scares me is that git fsck --full didn't find any problems on the old clone where it reproducibly fails. Did I win the hash collision lottery? 😕

Anyway, sorry for the noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LnL7 @xeji @GrahamcOfBorg