Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emacs cask version update and wrapper #42419

Merged
merged 2 commits into from Jul 14, 2018
Merged

Emacs cask version update and wrapper #42419

merged 2 commits into from Jul 14, 2018

Conversation

bennyandresen
Copy link
Contributor

Motivation for this change

emacsPackages.cask was updated to 0.8.4
cask was not properly executing the cask script, but rather https://github.com/AdrieanKhisbe/cask-package-toolset.el which is an "add-on"

We should review if a top-level cask even has a reason for existing.

emacsPackage.cask can be installed and works fine (has bin/)
emacsPackageNg.cask can be installed but lacks bin/

I've now adapted the top-level cask wrapper to reference emacsPackages.cask but I'm quite sure this reference won't update when emacsPackages.cask is updated. Only a reinstall/install will properly fix it, AFAICS.

Maintainers of the packages notificaiton:
@bendlas @jgeerds

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@bendlas
Copy link
Contributor

bendlas commented Jun 25, 2018

I see, that you pinged me about this on chat. Thanks for taking care of it

@bendlas
Copy link
Contributor

bendlas commented Jun 25, 2018

I'll test and merge it later in the evening ..

@bendlas bendlas self-assigned this Jun 25, 2018
@matthewbauer
Copy link
Member

Ping @bendlas

@bendlas
Copy link
Contributor

bendlas commented Jul 14, 2018

Oh, sorry, totally forgot ...
OK, so it seems that I completely mistook the purpose of cask-package-toolset, and also that I was developing against emacsPackagesNg, due to an override in my nixpkgs-config. The only explaination I have, is that i mistakenly merged a WIP commit from my HEAD.

@bendlas bendlas merged commit e805874 into NixOS:master Jul 14, 2018
@bendlas
Copy link
Contributor

bendlas commented Jul 14, 2018

I've created an issue for emacsPackagesNg: #43521

@bendlas
Copy link
Contributor

bendlas commented Jul 14, 2018

... and I've killed the top-level cask derivation: a6f0ff3

bendlas added a commit that referenced this pull request Jul 14, 2018
@bendlas
Revert "cask: init"
a6f0ff3 
This reverts commit 5bede1a.

This commit never actually wrapped cask, so it can be safely removed.

see #42419
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bendlas bendlas

Labels
6.topic: emacs 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bennyandresen @bendlas @matthewbauer @GrahamcOfBorg