Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pgmanage: 10.1.1 -> 10.3.0 #42422

Merged
merged 1 commit into from Jun 24, 2018
Merged

pgmanage: 10.1.1 -> 10.3.0 #42422

merged 1 commit into from Jun 24, 2018

Conversation

basvandijk
Copy link
Member

Motivation for this change

Release notes: https://github.com/pgManage/pgManage/releases/tag/v10.3.0

Also fixes #40247

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@infinisil
Copy link
Member

@GrahamcOfBorg test pgmanage

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.pgmanage

Partial log (click to expand)

one: exit status 1
syncing
one: running command: sync
one: exit status 0
test script finished in 13.47s
cleaning up
killing one (pid 593)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/lvgqk359m5qmxah6kxbilz2z2vg72iln-vm-test-run-pgmanage

infinisil
infinisil approved these changes Jun 24, 2018
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gonna trust in @basvandijk for hopefully having done more extensive tests than I could do or the current nixos test does :)

@basvandijk
Copy link
Member Author

@infinisil I'm running it on my (18.03) system and it appears to work correctly. I executed a few queries and browsed some tables.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.pgmanage

Partial log (click to expand)

one: exit status 1
syncing
one: running command: sync
one: exit status 0
test script finished in 36.51s
cleaning up
killing one (pid 627)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/2x97skwl1a1kfj2cz33m3a9bbkfxbc6s-vm-test-run-pgmanage

@basvandijk
Copy link
Member Author

When this is merged it would also be good to cherry-pick this on 18.03 which I've done in PR #42427.

@xeji xeji merged commit b7f60f2 into NixOS:master Jun 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pgmanage docs "installed as" incorrect (minor)
4 participants
@basvandijk @infinisil @GrahamcOfBorg @xeji