Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.plaid-python: init at 2.3.0 #42530

Merged
merged 2 commits into from Jun 25, 2018
Merged

pythonPackages.plaid-python: init at 2.3.0 #42530

merged 2 commits into from Jun 25, 2018

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Jun 24, 2018 •
edited

Motivation for this change

Using this as a library for other applications that access financial data through Plaid.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@bhipple bhipple requested a review from FRidh as a code owner June 24, 2018 16:16
@bhipple
Copy link
Contributor Author

bhipple commented Jun 24, 2018

@GrahamcOfBorg build pythonPackages.plaid-python

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pythonPackages.plaid-python

Partial log (click to expand)

writing dependency_links to plaid_python.egg-info/dependency_links.txt
reading manifest file 'plaid_python.egg-info/SOURCES.txt'
writing manifest file 'plaid_python.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/vidl3dapsfigf8srjk754k7cybvxp0hg-python2.7-plaid-python-2.3.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pythonPackages.plaid-python

Partial log (click to expand)

writing dependency_links to plaid_python.egg-info/dependency_links.txt
reading manifest file 'plaid_python.egg-info/SOURCES.txt'
writing manifest file 'plaid_python.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/jayy1k06jp4vvz1c4slmmv0v3y5favv3-python2.7-plaid-python-2.3.0

@FRidh
Copy link
Member

FRidh commented Jun 24, 2018 

Ran 0 tests in 0.000s

No tests are found. Either the test runner cannot find tests and needs to be patched, or there simply are no tests in which case the tests need to be disabled. Do include a comment explaining why the tests are disabled.

@bhipple
Copy link
Contributor Author

bhipple commented Jun 24, 2018

I spent a while trying to patch upstream's setup.py to run the tests, but wasn't quite able to get there. It looks like they just run their tests via their Makefile in travis instead of using the proper python packaging tests, so I've marked it as doCheck = false; with a comment.

@FRidh
Copy link
Member

FRidh commented Jun 24, 2018

Check their tox.ini for what to run.

@bhipple
Copy link
Contributor Author

bhipple commented Jun 24, 2018

Ah, I see there's even a section about py.test in the the python.section.md portion of the manual. I was able to get the unit tests running with this! Thanks!

@FRidh
Copy link
Member

FRidh commented Jun 25, 2018

@GrahamcOfBorg build pythonPackages.plaid-python @GrahamcOfBorg build python3Packages.plaid-python

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python3Packages.plaid-python

Partial log (click to expand)

running install tests
============================= test session starts ==============================
platform linux -- Python 3.6.5, pytest-3.6.2, py-1.5.3, pluggy-0.6.0
rootdir: /build/plaid-python-2.3.0, inifile:
collected 1 item

tests/unit/test_errors.py .                                              [100%]

=========================== 1 passed in 0.30 seconds ===========================
/nix/store/ql542gbdh2v8xvx31m4v4dz5lvz6imz1-python3.6-plaid-python-2.3.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pythonPackages.plaid-python

Partial log (click to expand)

running install tests
============================= test session starts ==============================
platform linux2 -- Python 2.7.15, pytest-3.6.2, py-1.5.3, pluggy-0.6.0
rootdir: /build/plaid-python-2.3.0, inifile:
collected 1 item

tests/unit/test_errors.py .                                              [100%]

=========================== 1 passed in 0.29 seconds ===========================
/nix/store/1sxs6yjngzm311wsqdqks573fq4k7a0b-python2.7-plaid-python-2.3.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pythonPackages.plaid-python

Partial log (click to expand)

running install tests
============================= test session starts ==============================
platform linux2 -- Python 2.7.15, pytest-3.6.2, py-1.5.3, pluggy-0.6.0
rootdir: /build/plaid-python-2.3.0, inifile:
collected 1 item

tests/unit/test_errors.py .                                              [100%]

=========================== 1 passed in 0.78 seconds ===========================
/nix/store/dxhjg8f9vdlyriyz9m9hfmdi8pjihyyh-python2.7-plaid-python-2.3.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python3Packages.plaid-python

Partial log (click to expand)

running install tests
============================= test session starts ==============================
platform linux -- Python 3.6.5, pytest-3.6.2, py-1.5.3, pluggy-0.6.0
rootdir: /build/plaid-python-2.3.0, inifile:
collected 1 item

tests/unit/test_errors.py .                                              [100%]

=========================== 1 passed in 1.15 seconds ===========================
/nix/store/542p5hx12pqnxx2wv96cvcynpcsvnq5x-python3.6-plaid-python-2.3.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: pythonPackages.plaid-python

Partial log (click to expand)

running install tests
============================= test session starts ==============================
platform darwin -- Python 2.7.15, pytest-3.6.2, py-1.5.3, pluggy-0.6.0
rootdir: /private/tmp/nix-build-python2.7-plaid-python-2.3.0.drv-0/plaid-python-2.3.0, inifile:
collected 1 item

tests/unit/test_errors.py .                                              [100%]

=========================== 1 passed in 0.34 seconds ===========================
/nix/store/687djsp32ngxm03jmcq95h1rk7r7f90w-python2.7-plaid-python-2.3.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python3Packages.plaid-python

Partial log (click to expand)

running install tests
============================= test session starts ==============================
platform darwin -- Python 3.6.5, pytest-3.6.2, py-1.5.3, pluggy-0.6.0
rootdir: /private/tmp/nix-build-python3.6-plaid-python-2.3.0.drv-0/plaid-python-2.3.0, inifile:
collected 1 item

tests/unit/test_errors.py .                                              [100%]

=========================== 1 passed in 0.44 seconds ===========================
/nix/store/7v4wbx1dsd38pq3vqyivfr3xjq07680a-python3.6-plaid-python-2.3.0

@xeji xeji merged commit 6e146c3 into NixOS:master Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bhipple @GrahamcOfBorg @FRidh @xeji