Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark more unfree licenses as unfree. #42531

Merged
merged 1 commit into from Jun 24, 2018

Conversation

Zimmi48
Copy link
Member

@Zimmi48 Zimmi48 commented Jun 24, 2018

See also #20256.

@Profpatsch
Copy link
Member

Bear in mind that this might break (more than) a few packages, because of transitive dependencies that are now unfree.

@Zimmi48
Copy link
Member Author

Zimmi48 commented Jun 24, 2018

Break of just make them not compiled by Hydra?

@7c6f434c
Copy link
Member

I wouldn't expect a widely used dependency to be under the licenses in question…

It seems to me that ofborg expects no breakage…

@7c6f434c 7c6f434c merged commit afb4b59 into NixOS:master Jun 24, 2018
@Zimmi48 Zimmi48 deleted the mark-more-unfree-licenses-as-unfree branch June 24, 2018 17:00
@Profpatsch
Copy link
Member

Awesome.

@vcunat
Copy link
Member

vcunat commented Jun 27, 2018

AFAIK ofborg wouldn't detect packages "disappearing". The rebuild counts are basically newly-appearing out-hashes.

@vcunat
Copy link
Member

vcunat commented Jun 27, 2018

The corresponding removed list on Hydra: https://hydra.nixos.org/eval/1465511#tabs-removed (it's over fifty commits together)

@7c6f434c
Copy link
Member

@vcunat I do know that at some point it did at least calculate the list of removed packages; maybe there is no easily accessible statistics, though.

@vcunat
Copy link
Member

vcunat commented Jun 27, 2018

I didn't know that. Anyway, the list seems OK to me, mostly themes and fonts, probably easy to build.

@Zimmi48
Copy link
Member Author

Zimmi48 commented Jun 27, 2018

We could indeed have kept these licenses marked as "free" with a comment because they are non-free but redistributable, as for redistributableFirmware. However, I guess it would be much better to separate the two pieces of information indeed. What can be built on Hydra is a different question than what the user can install if they only want free software.

@7c6f434c
Copy link
Member

Note that redistributable firmware is also firmware, which also affects many users' willingness to compromise.

And missing firmware is exactly the situation that breaks WiFi (and newcomers might want to read an explanation online), so we are more willing to compromise.

As long as we don't have an unfree but redistributable package with the build not dominated by unpacking, we can probably mark unfree non-firmware stuff unfree and let the endpoint machines unpack the icon themes.

@vcunat
Copy link
Member

vcunat commented Jun 27, 2018

IMHO hydra.nixos.org might accept most of the redistributable stuff, at least legally it should be OK. I believe it's primarily just about the degree "we" want to "support" software that is "unfree" in some sense. There's been lots of discussion even about how (not) to list unfree packages by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants