Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lollypop: 0.9.514 -> 0.9.516 #42451

Merged
merged 2 commits into from Jun 25, 2018
Merged

lollypop: 0.9.514 -> 0.9.516 #42451

merged 2 commits into from Jun 25, 2018

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

package bump

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Jun 24, 2018

@GrahamcOfBorg build lollypop

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: lollypop

Partial log (click to expand)

Receiving objects: 100% (204/204), 399.49 KiB | 760.00 KiB/s, done.
Resolving deltas: 100% (52/52), done.
From https://gitlab.gnome.org/World/lollypop
 * tag               0.9.515    -> FETCH_HEAD
Switched to a new branch 'fetchgit'
Submodule 'subprojects/po' (https://gitlab.gnome.org/gnumdk/lollypop-po) registered for path 'subprojects/po'
error: key does not contain a section: .url
builder for '/nix/store/pwvwhaf9747j0dqv5fq8c5zr7qh4svyy-lollypop.drv' failed with exit code 1
cannot build derivation '/nix/store/3n2bmxjmcbi2c65na0bsskj8q6gnp1b0-lollypop-0.9.515.drv': 1 dependencies couldn't be built
error: build of '/nix/store/3n2bmxjmcbi2c65na0bsskj8q6gnp1b0-lollypop-0.9.515.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: lollypop

Partial log (click to expand)

Receiving objects: 100% (204/204), 399.49 KiB | 1.30 MiB/s, done.
Resolving deltas: 100% (52/52), done.
From https://gitlab.gnome.org/World/lollypop
 * tag               0.9.515    -> FETCH_HEAD
Switched to a new branch 'fetchgit'
Submodule 'subprojects/po' (https://gitlab.gnome.org/gnumdk/lollypop-po) registered for path 'subprojects/po'
error: key does not contain a section: .url
builder for '/nix/store/q87y0i9q8833pnv6m2ylna2vn60mgkva-lollypop.drv' failed with exit code 1
cannot build derivation '/nix/store/7c42x4188k7mwws1i9yf53ih0nfimjrl-lollypop-0.9.515.drv': 1 dependencies couldn't be built
error: build of '/nix/store/7c42x4188k7mwws1i9yf53ih0nfimjrl-lollypop-0.9.515.drv' failed

@xeji
Copy link
Contributor

xeji commented Jun 24, 2018

doesn't build.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: lollypop

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@worldofpeace worldofpeace changed the title lollypop: 0.9.514 -> 0.9.515 lollypop: 0.9.514 -> 0.9.516 Jun 25, 2018
@worldofpeace
Copy link
Contributor Author

Edit: This package recieved an update again today. I changed the pr to apply this.

As for the build failure, it fails when trying to get the translations submodule

Submodule 'subprojects/po' (https://gitlab.gnome.org/gnumdk/lollypop-po) registered for path 'subprojects/po'
error: key does not contain a section: .url

I don't get this error because I'm not familar with how fetchgit works.
@xeji Any suggestions?

@worldofpeace
Copy link
Contributor Author

Ah I see now that this is because of this #42376 right?

@xeji
Copy link
Contributor

xeji commented Jun 25, 2018

Probably. The git update was reverted. Let's see if this builds now.
@GrahamcOfBorg build lollypop

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: lollypop

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: lollypop

Partial log (click to expand)

Wrapping program /nix/store/jwf80hf9fl6sgfigf1sq42lbay2djy5p-lollypop-0.9.516/bin/lollypop-cli
Wrapping program /nix/store/jwf80hf9fl6sgfigf1sq42lbay2djy5p-lollypop-0.9.516/libexec/lollypop-sp
shrinking RPATHs of ELF executables and libraries in /nix/store/jwf80hf9fl6sgfigf1sq42lbay2djy5p-lollypop-0.9.516
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/jwf80hf9fl6sgfigf1sq42lbay2djy5p-lollypop-0.9.516/lib  /nix/store/jwf80hf9fl6sgfigf1sq42lbay2djy5p-lollypop-0.9.516/libexec  /nix/store/jwf80hf9fl6sgfigf1sq42lbay2djy5p-lollypop-0.9.516/bin
patching script interpreter paths in /nix/store/jwf80hf9fl6sgfigf1sq42lbay2djy5p-lollypop-0.9.516
checking for references to /build in /nix/store/jwf80hf9fl6sgfigf1sq42lbay2djy5p-lollypop-0.9.516...
wrapping `/nix/store/jwf80hf9fl6sgfigf1sq42lbay2djy5p-lollypop-0.9.516/bin/.lollypop-wrapped'...
wrapping `/nix/store/jwf80hf9fl6sgfigf1sq42lbay2djy5p-lollypop-0.9.516/bin/.lollypop-cli-wrapped'...
/nix/store/jwf80hf9fl6sgfigf1sq42lbay2djy5p-lollypop-0.9.516

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: lollypop

Partial log (click to expand)

Wrapping program /nix/store/p9aj93ccln8j1idn6axxmn2kjkgig23b-lollypop-0.9.516/bin/lollypop
Wrapping program /nix/store/p9aj93ccln8j1idn6axxmn2kjkgig23b-lollypop-0.9.516/libexec/lollypop-sp
shrinking RPATHs of ELF executables and libraries in /nix/store/p9aj93ccln8j1idn6axxmn2kjkgig23b-lollypop-0.9.516
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/p9aj93ccln8j1idn6axxmn2kjkgig23b-lollypop-0.9.516/lib  /nix/store/p9aj93ccln8j1idn6axxmn2kjkgig23b-lollypop-0.9.516/libexec  /nix/store/p9aj93ccln8j1idn6axxmn2kjkgig23b-lollypop-0.9.516/bin
patching script interpreter paths in /nix/store/p9aj93ccln8j1idn6axxmn2kjkgig23b-lollypop-0.9.516
checking for references to /build in /nix/store/p9aj93ccln8j1idn6axxmn2kjkgig23b-lollypop-0.9.516...
wrapping `/nix/store/p9aj93ccln8j1idn6axxmn2kjkgig23b-lollypop-0.9.516/bin/.lollypop-wrapped'...
wrapping `/nix/store/p9aj93ccln8j1idn6axxmn2kjkgig23b-lollypop-0.9.516/bin/.lollypop-cli-wrapped'...
/nix/store/p9aj93ccln8j1idn6axxmn2kjkgig23b-lollypop-0.9.516

@xeji xeji merged commit 1a54248 into NixOS:master Jun 25, 2018
@worldofpeace worldofpeace deleted the lollypop-0.9.515 branch June 25, 2018 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants