Disable fortify and stackprotector hardening for spl/zfs. #42430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Mic92 Please have a look. I think that we should not allow different gcc hardening settings for out-of-tree module compilations and for the kernel. I would have this setting passed through from the kernel derivation so that we can ensure that the ABI matches with the module. This is something for a followup PR, probably going through all the packages in "linuxPackagesFor". |
|
This works with Linux 4.16.17 and ZFS on my system. |
Linux 4.16 introduces a stackprotector detection script that returns different results for the kernel compilation run and the spl/zfs compilation run, as the setting for hardening are different. This results in a broken ABI between spl/zfs and the compiled kernel, breaking ZFS. Also disabling the fortify and stackprotector hardening, as we do for the kernel, fixes that.
clefru
force-pushed
the
zfs-v4.16-hardening-adjust
branch
from
0c86bb4
to
758dc06
Compare
|
While "master" seems not to care, cherry-picking into release-18.03 doesn't give working spl/zfs modules unless I also disable the "fortify" hardening for the spl/zfs compilation branch. I updated the PR with that, so we cherry-pick into 18.03 |
clefru
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linux 4.16 introduces a stackprotector detection script that returns
different results for the kernel compilation run and the spl/zfs
compilation run, as the setting for hardening are different. This
results in a broken ABI between spl/zfs and the compiled kernel,
breaking ZFS. Also disabling the fortify and stackprotector hardening,
as we do for the kernel, fixes that.
Motivation for this change
#39225
Things done
sandboxinnix.confon non-NixOS)nix-build -A stable nixos/tests/zfs.nixnix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)