Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boost cross compilation fixes #42476

Merged
merged 2 commits into from Jun 24, 2018
Merged

Boost cross compilation fixes #42476

merged 2 commits into from Jun 24, 2018

Conversation

matthewbauer
Copy link
Member

Motivation for this change

We had some issues with how we communicated to boost what our system was. This uses the new cross system stuff to give it "parsed" information instead of having it guess what to do. Should hopefully fix a couple in #42407.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: boost

Partial log (click to expand)

/nix/store/akmfwagjcvhr59psyiycv6mjq7x0r0xj-boost-1.67_0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: boost

Partial log (click to expand)

these paths will be fetched (10.07 MiB download, 48.62 MiB unpacked):
  /nix/store/kg1kba3r1vgqabr7gwkvihwdnd7hf5v6-icu4c-59.1
  /nix/store/p8qc8f7kqdpmc8zzfzv48xi0hm13w1ai-boost-1.67_0
copying path '/nix/store/kg1kba3r1vgqabr7gwkvihwdnd7hf5v6-icu4c-59.1' from 'https://cache.nixos.org'...
copying path '/nix/store/p8qc8f7kqdpmc8zzfzv48xi0hm13w1ai-boost-1.67_0' from 'https://cache.nixos.org'...
/nix/store/p8qc8f7kqdpmc8zzfzv48xi0hm13w1ai-boost-1.67_0

@matthewbauer matthewbauer merged commit 49a16a2 into NixOS:master Jun 24, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: boost

Partial log (click to expand)

/nix/store/d30wadhgv8rpfn33kh58w6b1q5r1sqwi-boost-1.67_0

@dtzWill
Copy link
Member

dtzWill commented Jun 24, 2018

❤️

Thanks! Kicking off builds to test overnight but LGTM!

And yes the __stack_chk_guard (err whatever it is) is definitely related to stack-protector hardening, it's provided by the stack protector runtime--which is sometimes built/provided by gcc and sometimes by libc. No clue how that's done with mingw :).

@dtzWill
Copy link
Member

dtzWill commented Jun 24, 2018

This... seems to fix cross-aarch64-musl build of nixUnstable, and probably all the other ones broken similarly. Woohoo! Thanks!

@matthewbauer matthewbauer deleted the boost-cross branch June 27, 2018 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314 Ericson2314 is a code owner

@orivej orivej Awaiting requested review from orivej

@dtzWill dtzWill Awaiting requested review from dtzWill

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matthewbauer @GrahamcOfBorg @dtzWill