Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lua5.3/pkgconfig: add lua5.3.pc #42473

Merged
merged 1 commit into from Jul 6, 2018
Merged

lua5.3/pkgconfig: add lua5.3.pc #42473

merged 1 commit into from Jul 6, 2018

Conversation

roosemberth
Copy link
Contributor

Some applications try to build using pkgconfig lua5.3 --libs... as some major
distributions use this name. Add a symlink to the lua.pc pkgconfig file.

Signed-off-by: Roosembert Palacios roosembert.palacios@epfl.ch

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

lua5.3/pkgconfig: add lua5.3.pc
1f44c02 
Some applications try to build using `pkgconfig lua5.3 --libs...` as some major
distributions use this name. Add a symlink to the lua.pc pkgconfig file.

Signed-off-by: Roosembert Palacios <roosembert.palacios@epfl.ch>
@andir
Copy link
Member

andir commented Jun 28, 2018 •
edited

Looks not to bad and I can see where the need for that change comes from. Is
that something we should be doing for all the lua variants?

@roosemberth
Copy link
Contributor Author

Probably, actually I discover the need for this while packaging ocvm: https://gitlab.com/roosemberth/dotfiles/commit/60b6bb4355b96207aa9eb57d4299465ca2343db5
https://github.com/payonel/ocvm

@matthewbauer matthewbauer merged commit e67fb11 into NixOS:master Jul 6, 2018
@roosemberth roosemberth deleted the lua53-pkgconfig branch October 16, 2019 13:46
@jakobrs jakobrs mentioned this pull request Jan 23, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@roosemberth @andir @matthewbauer @GrahamcOfBorg