Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mesa: 18.0.3 -> 18.1.2 #42467

Merged
merged 2 commits into from Jul 6, 2018
Merged

mesa: 18.0.3 -> 18.1.2 #42467

merged 2 commits into from Jul 6, 2018

Conversation

mkaito
Copy link
Contributor

@mkaito mkaito commented Jun 23, 2018 •
edited

Motivation for this change

Update to latest stable mesa

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@mkaito
Copy link
Contributor Author

mkaito commented Jun 24, 2018 •
edited

I've got another PR coming up for mesa that fixes pkgconfig paths for some things. Maybe merge them together to avoid doing the massive rebuild twice.

Edit: #42529

@xeji
Copy link
Contributor

xeji commented Jun 24, 2018

Please rebase this PR on the staging branch since it causes a mass rebuild.

@mkaito mkaito requested a review from FRidh as a code owner June 25, 2018 20:32
@mkaito
Copy link
Contributor Author

mkaito commented Jun 25, 2018

rebased

@FRidh FRidh changed the base branch from master to staging June 25, 2018 20:36
FRidh
FRidh requested changes Jun 25, 2018
View reviewed changes
pkgs/development/libraries/mesa/default.nix Outdated
@@ -2,7 +2,7 @@
, pkgconfig, intltool, autoreconfHook, substituteAll
, file, expat, libdrm, xorg, wayland, wayland-protocols, openssl
, llvmPackages, libffi, libomxil-bellagio, libva-minimal
, libelf, libvdpau, valgrind-light, python2
, libelf, libvdpau, valgrind-light, python2, python27Packages
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pass in either python or pythonPackages, not both.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I reference Mako (why is that capitalized?) from python2 instead of python27Packages?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can reference packages like this: python2.pkgs.Mako.

@mkaito
Copy link
Contributor Author

mkaito commented Jun 26, 2018

Done.

I've been running it for a few days now. Seems stable, and actually seems to improve performance on some games.

@Chiiruno
Copy link
Contributor

Chiiruno commented Jun 27, 2018 •
edited

I've been running it for a few days now. Seems stable, and actually seems to improve performance on some games.

Mesa implements Vulkan right? Hopefully it'll fix that EFB problem I've been having with dolphin-emu.

@matthewbauer matthewbauer merged commit b29440f into NixOS:staging Jul 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji left review comments

@FRidh FRidh FRidh requested changes

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mkaito @xeji @Chiiruno @FRidh @matthewbauer @GrahamcOfBorg